Skip to content

Commit

Permalink
remove kubectl installation from README
Browse files Browse the repository at this point in the history
Signed-off-by: Piotr Pawłowski <[email protected]>
  • Loading branch information
pawloch00 committed Jan 14, 2025
1 parent 839e75e commit 44d7deb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
11 changes: 3 additions & 8 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ BIN_PATH=$(PROJECT_DIR)/bin
install: check-python check-gcloud install-kueuectl install-kjob pip-install

.PHONY: install-dev
install-dev: check-python check-gcloud mkdir-bin install-kubectl install-kueuectl install-kjob pip-install install-pytest
install-dev: check-python check-gcloud mkdir-bin install-kueuectl install-kjob pip-install install-pytest

.PHONY: pip-install
pip-install:
Expand All @@ -36,7 +36,7 @@ run-integrationtests:
pytest src/xpk/core/tests/integration/

.PHONY: install-kjob
install-kjob: install-kubectl
install-kjob:
docker build -f tools/Dockerfile-kjob -t $(KJOB_DOCKER_IMG) tools/
docker run -idt --name $(KJOB_DOCKER_CONTAINER) $(KJOB_DOCKER_IMG)
docker cp $(KJOB_DOCKER_CONTAINER):/kjob/bin/kubectl-kjob $(BIN_PATH)/kubectl-kjob
Expand All @@ -47,13 +47,8 @@ install-kjob: install-kubectl
mkdir-bin:
mkdir -p $(BIN_PATH)

.PHONY: install-kubectl
install-kubectl: mkdir-bin
gcloud components install kubectl
gcloud components install gke-gcloud-auth-plugin

.PHONY: install-kueuectl
install-kueuectl: install-kubectl
install-kueuectl:
curl -Lo $(BIN_PATH)/kubectl-kueue $(KUEUECTL_URL)
chmod +x $(BIN_PATH)/kubectl-kueue

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ Following tools must be installed:
- gcloud (install from [here](https://cloud.google.com/sdk/gcloud#download_and_install_the))
- Run `gcloud init`
- [Authenticate](https://cloud.google.com/sdk/gcloud/reference/auth/application-default/login) to Google Cloud
- kubectl (install from [here](https://cloud.google.com/kubernetes-engine/docs/how-to/cluster-access-for-kubectl) together with [required plugins](https://cloud.google.com/kubernetes-engine/docs/how-to/cluster-access-for-kubectl#install_plugin))
- docker ([installation instruction](https://docs.docker.com/engine/install/))
- Run `gcloud auth configure-docker` to ensure images can be uploaded to registry
- make - please run below command.
Expand All @@ -84,7 +85,6 @@ Following tools must be installed:
apt-get -y install make
```
In addition, below dependencies will be installed with `make install` command:
- kubectl (install from [here](https://kubernetes.io/docs/tasks/tools/))
- kueuectl (install from [here](https://kueue.sigs.k8s.io/docs/reference/kubectl-kueue/installation/))
- kjob (installation instructions [here](https://github.com/kubernetes-sigs/kjob/blob/main/docs/installation.md))

Expand Down

0 comments on commit 44d7deb

Please sign in to comment.