Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fewer packageManager assumptions #11012

Merged
merged 8 commits into from
Feb 18, 2025
Merged

fewer packageManager assumptions #11012

merged 8 commits into from
Feb 18, 2025

Conversation

turadg
Copy link
Member

@turadg turadg commented Feb 18, 2025 •
edited
Loading

refs: #451

Description

Several commits from #9945 to support #451 .

Also for testing Agoric/testnet-load-generator#122 (comment) against agoric-sdk.

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

none

Testing Considerations

CI suffices. The CLI changes are covered.

Upgrade Considerations

n/a

@turadg turadg requested a review from mhofman February 18, 2025 16:12
@turadg turadg requested a review from a team as a code owner February 18, 2025 16:12
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 18, 2025 •
edited
Loading

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: a111596
Status: ✅  Deploy successful!
Preview URL: https://a80b7e72.agoric-sdk.pages.dev
Branch Preview URL: https://451-loadgen.agoric-sdk.pages.dev

View logs

@turadg turadg added the force:integration Force integration tests to run on PR label Feb 18, 2025
@turadg turadg mentioned this pull request Feb 18, 2025
Merged
@turadg turadg requested a review from michaelfig February 18, 2025 19:15
michaelfig
michaelfig approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Feb 18, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 18, 2025

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #11012 has been manually updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@turadg
Copy link
Member Author

turadg commented Feb 18, 2025

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 18, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 18, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot merged commit 987bcf1 into master Feb 18, 2025
83 checks passed
@mergify mergify bot deleted the 451-loadgen branch February 18, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfig michaelfig michaelfig approved these changes

@mhofman mhofman Awaiting requested review from mhofman

Assignees
No one assigned
Labels
automerge:rebase Automatically rebase updates, then merge force:integration Force integration tests to run on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turadg @michaelfig