Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn 4 compatibility #122

Merged
merged 7 commits into from
Feb 18, 2025
Merged

Yarn 4 compatibility #122

merged 7 commits into from
Feb 18, 2025

Conversation

turadg
Copy link
Member

@turadg turadg commented Feb 13, 2025

Unlocked by: #119

Make runner use Yarn 4, aligning with,

Also gc's some unused deps.

@turadg turadg force-pushed the ta/yarn4-compat branch 2 times, most recently from 7556833 to 9cc503b Compare February 13, 2025 18:10
Base automatically changed from usman/monitoring-follower to main February 17, 2025 05:29
@turadg turadg marked this pull request as ready for review February 17, 2025 14:56
Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally approved but I would like to see a manual run of agoric-sdk integration CI against this branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize we had these unused dependencies. How were these discovered?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked to update old deps and discovered 'Ava' isn't used at all. That led me to search for more.

@turadg
Copy link
Member Author

turadg commented Feb 17, 2025

Conditionally approved but I would like to see a manual run of agoric-sdk integration CI against this branch.

Why isn't the job here sufficient?

https://github.com/Agoric/testnet-load-generator/actions/runs/13373023157/job/37345765222

Kind of a pain to have to do another PR in another repo to find out if this is safe to merge.

@mhofman
Copy link
Member

mhofman commented Feb 17, 2025

Because unfortunately the job here is only an approximation of what the agoric-sdk CI does and in this case I believe the approximation is not sufficient. And yes I agree we need a better story for cross repo integration tests.

Related: endojs/endo#1866

@turadg
Copy link
Member Author

turadg commented Feb 18, 2025

Agoric/agoric-sdk#11012 with #loadgen-branch: ta/yarn4-compat passed in https://github.com/Agoric/agoric-sdk/actions/runs/13395243555/job/37412555616?pr=11012

@turadg turadg merged commit 4b8b250 into main Feb 18, 2025
3 checks passed
@turadg turadg deleted the ta/yarn4-compat branch February 18, 2025 18:41
mergify bot added a commit to Agoric/agoric-sdk that referenced this pull request Feb 18, 2025
refs: #451

## Description
Several commits from #9945 to support #451 .  

Also for testing Agoric/testnet-load-generator#122 (comment) against agoric-sdk. 

### Security Considerations
none

### Scaling Considerations
none

### Documentation Considerations
none

### Testing Considerations
CI suffices. The CLI changes are covered.

### Upgrade Considerations
n/a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants