-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yarn 4 compatibility #122
Yarn 4 compatibility #122
Conversation
7556833
to
9cc503b
Compare
9cc503b
to
f11dc5f
Compare
8ec0dbc
to
888b454
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conditionally approved but I would like to see a manual run of agoric-sdk integration CI against this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize we had these unused dependencies. How were these discovered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked to update old deps and discovered 'Ava' isn't used at all. That led me to search for more.
Why isn't the job here sufficient? https://github.com/Agoric/testnet-load-generator/actions/runs/13373023157/job/37345765222 Kind of a pain to have to do another PR in another repo to find out if this is safe to merge. |
Because unfortunately the job here is only an approximation of what the agoric-sdk CI does and in this case I believe the approximation is not sufficient. And yes I agree we need a better story for cross repo integration tests. Related: endojs/endo#1866 |
Agoric/agoric-sdk#11012 with |
refs: #451 ## Description Several commits from #9945 to support #451 . Also for testing Agoric/testnet-load-generator#122 (comment) against agoric-sdk. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations CI suffices. The CLI changes are covered. ### Upgrade Considerations n/a
Unlocked by: #119
Make runner use Yarn 4, aligning with,
Also gc's some unused deps.