Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spell check output in comment #105

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Add spell check output in comment #105

merged 4 commits into from
Mar 27, 2024

Conversation

jashapiro
Copy link
Member

closes #96

Since spelling errors due to names and such seem to be common, I decided that rather than making the workflow fail on spelling errors, it would be better to just print out the number of spelling errors in the artifact comment, so that is what I have done here.

I count the total number of errors by their locations, not the number of indepdendent errors. This was partly because I found that the locations file only includes the content files, while the spelling-errors.txt file also included errors in the frontmatter, which are mostly names.

I also implemented failure for manual triggers, but I don't expect that to be used much.

The first build here should demonstrate the output, if it is working.

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit dc9ed09.

Manuscript build

There were 18 spelling errors.
Check the build link above for details.

@jashapiro jashapiro requested a review from sjspielman March 27, 2024 01:55
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 2e2e867.

Manuscript build

There were 6 spelling errors.
Check the build link above for details.

Copy link
Member

@sjspielman sjspielman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jashapiro jashapiro merged commit e95df63 into main Mar 27, 2024
1 check passed
@jashapiro jashapiro deleted the jashapiro/spelling-fail branch March 27, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make manubot action fail for spelling errors
2 participants