Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Figure 1 legend #33

Merged
merged 6 commits into from
Feb 26, 2024
Merged

Add Figure 1 legend #33

merged 6 commits into from
Feb 26, 2024

Conversation

sjspielman
Copy link
Member

@sjspielman sjspielman commented Feb 15, 2024

Closes #10
This PR adds the legend for Figure 1. I placed (edit) it** in a file for figure/table legends that is numbered 100 to appear as the last file in the build.

Here is figure 1 for reference: https://github.com/AlexsLemonade/scpca-paper-figures/blob/2ebc50dd2c9071ceb2487d97b9daaf52f7c11826/figures/compiled_figures/pngs/figure_1.png

Questions for reviewers:

  • Is 100 the right order here, or should it be moved up before references?
  • More/less detail anywhere?
  • I struggled a little bit to clearly explain the colors in panel B and how modalities relate to the "all samples" bar. How did I do?

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit d3e09b3.

Manuscript build

@sjspielman sjspielman mentioned this pull request Feb 19, 2024
Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM

@jaclyn-taroni
Copy link
Member

jaclyn-taroni commented Feb 24, 2024

I know I approved this already, but can you put the figure itself in the figure legend (towards #48)? (This applies for all future PRs as well.) I know we don't have the final.final commit for the figures, so perhaps we want to use main for now and file an issue tracking updating to use a tagged release?

@sjspielman
Copy link
Member Author

I know I approved this already, but can you put the figure itself in the figure legend (towards #48)? (This applies for all future PRs as well.)

Do you mean, reformat the figure legend (still in its own file) to literally be written out as something like this?

![Caption for the example figure.](url_or_path_to_figure){#fig:example-id}

I know we don't have the final.final commit for the figures, so perhaps we want to use main for now and file an issue tracking updating to use a tagged release?

This makes sense to me, I'll open the issue.

@sjspielman sjspielman mentioned this pull request Feb 26, 2024
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 9a4a2bf.

Manuscript build

@sjspielman sjspielman merged commit 0528587 into main Feb 26, 2024
1 check passed
@sjspielman sjspielman deleted the sjspielman/10-fig1-legend branch February 26, 2024 20:37
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit a3b832a.

Manuscript build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure Legends: Fig 1
2 participants