-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Figure 1 legend #33
Conversation
Click the link below to download the manuscript build as a ZIP file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 LGTM
I know I approved this already, but can you put the figure itself in the figure legend (towards #48)? (This applies for all future PRs as well.) I know we don't have the final.final commit for the figures, so perhaps we want to use |
Do you mean, reformat the figure legend (still in its own file) to literally be written out as something like this?
This makes sense to me, I'll open the issue. |
Click the link below to download the manuscript build as a ZIP file. |
Click the link below to download the manuscript build as a ZIP file. |
Closes #10
This PR adds the legend for Figure 1. I placed (edit) it** in a file for figure/table legends that is numbered
100
to appear as the last file in the build.Here is figure 1 for reference: https://github.com/AlexsLemonade/scpca-paper-figures/blob/2ebc50dd2c9071ceb2487d97b9daaf52f7c11826/figures/compiled_figures/pngs/figure_1.png
Questions for reviewers:
100
the right order here, or should it be moved up before references?