-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Figure 2 caption* #36
Conversation
Just noting for context this discussion in |
Yes, I started to review this and I 100% agree. |
I set AlexsLemonade/scpca-paper-figures#66 as blocking. I'm going to remove my review request for now. |
Click the link below to download the manuscript build as a ZIP file. |
Click the link below to download the manuscript build as a ZIP file. |
Reviewing notes: Figure 1 caption was previously approved so that can serve as a guide for the level of detail expected in Figure 2. The Figure 2 caption also assumes that panels are as they appear in this open PR (not yet reflected in |
Click the link below to download the manuscript build as a ZIP file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks good, I just a few wording comments.
Co-authored-by: Ally Hawkins <[email protected]>
Click the link below to download the manuscript build as a ZIP file. |
I did a couple more rephrasings to be less wordy, including rearranging some of the words in 2B. Let me know how it's looking now! |
Click the link below to download the manuscript build as a ZIP file. |
Click the link below to download the manuscript build as a ZIP file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just two minor comments, but I don't need to see this again.
Co-authored-by: Ally Hawkins <[email protected]>
Click the link below to download the manuscript build as a ZIP file. |
Stacked on #33
Closes #11
This PR adds the legend for Figure 2. For Panel A, I described the workflow using option 3 from #11 (comment). For Panel B, I used semi-colons to separate out a description of each plot in the panel. While writing this, I wondered whether we actually want to make these real panels in their own right, as panels B-G, which may make it easier to read.
Again, let me know where text can be simplified and/or expanded!