Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Figure 2 caption* #36

Merged
merged 10 commits into from
Feb 27, 2024
Merged

Add Figure 2 caption* #36

merged 10 commits into from
Feb 27, 2024

Conversation

sjspielman
Copy link
Member

Stacked on #33
Closes #11

This PR adds the legend for Figure 2. For Panel A, I described the workflow using option 3 from #11 (comment). For Panel B, I used semi-colons to separate out a description of each plot in the panel. While writing this, I wondered whether we actually want to make these real panels in their own right, as panels B-G, which may make it easier to read.

Again, let me know where text can be simplified and/or expanded!

@sjspielman
Copy link
Member Author

Just noting for context this discussion in scpca-paper-figures about a slight "mismatch" between the panel itself and the legend, but one that should be fine given the other aspects of the paper where we describe cell type annotation more in depth: AlexsLemonade/scpca-paper-figures#63

@jaclyn-taroni
Copy link
Member

While writing this, I wondered whether we actually want to make these real panels in their own right, as panels B-G, which may make it easier to read.

Yes, I started to review this and I 100% agree.

@jaclyn-taroni
Copy link
Member

I set AlexsLemonade/scpca-paper-figures#66 as blocking. I'm going to remove my review request for now.

@jaclyn-taroni jaclyn-taroni removed their request for review February 24, 2024 19:10
Base automatically changed from sjspielman/10-fig1-legend to main February 26, 2024 20:36
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit b06ae68.

Manuscript build

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 14fa511.

Manuscript build

@sjspielman
Copy link
Member Author

Reviewing notes: Figure 1 caption was previously approved so that can serve as a guide for the level of detail expected in Figure 2. The Figure 2 caption also assumes that panels are as they appear in this open PR (not yet reflected in main): AlexsLemonade/scpca-paper-figures#69

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 4e3df9c.

Manuscript build

Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks good, I just a few wording comments.

content/100.figure-table-legends.md Outdated Show resolved Hide resolved
content/100.figure-table-legends.md Outdated Show resolved Hide resolved
content/100.figure-table-legends.md Outdated Show resolved Hide resolved
content/100.figure-table-legends.md Outdated Show resolved Hide resolved
content/100.figure-table-legends.md Outdated Show resolved Hide resolved
content/100.figure-table-legends.md Outdated Show resolved Hide resolved
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 0c1bfa7.

Manuscript build

@sjspielman
Copy link
Member Author

I did a couple more rephrasings to be less wordy, including rearranging some of the words in 2B. Let me know how it's looking now!

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit e3ebebf.

Manuscript build

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 9fa8024.

Manuscript build

@sjspielman sjspielman changed the title Add Figure 2 legend Add Figure 2 ~legend~ caption Feb 27, 2024
@sjspielman sjspielman changed the title Add Figure 2 ~legend~ caption Add Figure 2 caption* Feb 27, 2024
Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just two minor comments, but I don't need to see this again.

content/100.figure-table-legends.md Outdated Show resolved Hide resolved
content/100.figure-table-legends.md Outdated Show resolved Hide resolved
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 59ee0e7.

Manuscript build

@sjspielman sjspielman merged commit f801104 into main Feb 27, 2024
1 check passed
@sjspielman sjspielman deleted the sjspielman/11-fig2-legend branch February 27, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure legends: Fig 2
3 participants