Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fig S2 legend #67

Merged
merged 10 commits into from
Mar 6, 2024
Merged

Fig S2 legend #67

merged 10 commits into from
Mar 6, 2024

Conversation

sjspielman
Copy link
Member

Closes #14
Stacked on #66

This PR adds the S2 legend. It could use lots of feedback all around..!

One particular spot to look at is in panel A, where I sort wrote something that is not part of the figure - An ADT-by-cell count matrix is additionally produced and read into R along with the gene-by-cell count matrix. - the figure itself does not contain any indication of an ADT-by-cell matrix. What do you think about it? Cut it?

I'm also particularly interested to hear thoughts on panel B. I tried to relate it back to Figure 2 itself, but I can't tell if that is helpful or more confusing.

@sjspielman
Copy link
Member Author

Note to selves: no merging until the base is main so we can check the render!

@sjspielman sjspielman requested a review from allyhawkins March 4, 2024 21:33
Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, I just had a few thoughts on wording mostly around the CITE-seq part. I might tag in @jashapiro to look at the multiplexed workflow legend.

content/100.figure-table-legends.md Outdated Show resolved Hide resolved
@@ -138,6 +138,37 @@ Distributions reflect broad agreement between platforms in the total number of g
<!-- Figure S2 -->
![**Processing additional single-cell modalities in `scpca-nf`.**](https://raw.githubusercontent.com/AlexsLemonade/scpca-paper-figures/main/figures/compiled_figures/pngs/figure_s2.png?sanitize=true){#fig:figs2 tag="S2" width="7in"}

A. Overview of the `scpca-nf` workflow for CITE-seq libraries with antibody-derived tag (ADT) counts.
The workflow mirrors that shown in Figure {@fig:fig2}A with several differences accounting for the presence of ADT data.
First, both an RNA and ADT FASTQ file are inputted to `alevin-fry`, along with information about ADT barcodes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
First, both an RNA and ADT FASTQ file are inputted to `alevin-fry`, along with information about ADT barcodes.
First, both an RNA and ADT FASTQ file are required as input to `alevin-fry`, along with a TSV file containing infomation about ADT barcodes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A related question is we want to modify the figure itself to actually show an ADT-by-cell matrix? CC @dvenprasad, currently we show only a gene-by-cell matrix (S2A: https://github.com/AlexsLemonade/scpca-paper-figures/blob/main/figures/compiled_figures/pngs/figure_s2.png)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm I think we could, but I don't think it's entirely necessary. I'm worried about overcrowding. Maybe let's see if others have thoughts during review and you can add a comment there.

content/100.figure-table-legends.md Outdated Show resolved Hide resolved
content/100.figure-table-legends.md Outdated Show resolved Hide resolved
content/100.figure-table-legends.md Outdated Show resolved Hide resolved
content/100.figure-table-legends.md Outdated Show resolved Hide resolved
content/100.figure-table-legends.md Outdated Show resolved Hide resolved
@sjspielman sjspielman requested a review from allyhawkins March 5, 2024 18:28
Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two remaining comments but I don't need to see this again.

A. Overview of the `scpca-nf` workflow for processing libraries with CITE-seq or antibody-derived tag (ADT) derived data.
The workflow mirrors that shown in Figure {@fig:fig2}A with several differences accounting for the presence of ADT data.
First, both an RNA and ADT FASTQ file are required as input to `alevin-fry`, along with a TSV file containing infomation about ADT barcodes.
The gene-by-cell and ADT-by-cell count matrices are produced and read into `R` to create a `SingleCellExperiment` (SCE) object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add an html comment here to decide on if we should add in the ADT by cell matrix to the figure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, and once this goes in I'm also going to open an issue in the paper figures repo and link to this caption to gather thoughts there, too.

content/100.figure-table-legends.md Outdated Show resolved Hide resolved
Base automatically changed from sjspielman/legends-s3-s4-s5 to main March 6, 2024 14:46
Copy link

github-actions bot commented Mar 6, 2024

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit f3eaf86.

Manuscript build

@sjspielman sjspielman merged commit 51b1cdc into main Mar 6, 2024
1 check passed
@sjspielman sjspielman deleted the sjspielman/legend-s2 branch March 6, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure legends: Supplemental figures
2 participants