-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fig S2 legend #67
Merged
Merged
Fig S2 legend #67
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
44a1c71
add s2 legend
sjspielman d8b17bc
wrong panel
sjspielman 5ed0f1f
merge base branch
sjspielman c66465b
Merge branch 'sjspielman/legends-s3-s4-s5' into sjspielman/legend-s2
sjspielman 4a9d198
Apply suggestions from code review
sjspielman 771c912
Update content/100.figure-table-legends.md
sjspielman 3f412c7
add comment about do we want to update the figure
sjspielman f6d8a72
new line for rendering
sjspielman ddf584e
merge base branch
sjspielman f3eaf86
Merge branch 'main' into sjspielman/legend-s2
sjspielman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add an html comment here to decide on if we should add in the ADT by cell matrix to the figure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do, and once this goes in I'm also going to open an issue in the paper figures repo and link to this caption to gather thoughts there, too.