Handle large matrices and change default Seurat format #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing AlexsLemonade/OpenScPCA-analysis#953, I found that the sum counts function doesn't work with very large matrices, namely unfiltered matrices. We probably don't really need to support that, but it wasn't too hard to do, so I added a bit of splitting and merging to avoid ever creating a single very large non-sparse matrix.
(There was a fun edge case I ran into when the matrix was one larger than a multiple of the chunk size...)
After some more
Seurat
testing, I also discovered thatv5
is really the default for new objects, so we might as well make that our default too. So there are bunch of test changes related to that change in defaults.