Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiled figure updates #69

Merged
merged 16 commits into from
Feb 28, 2024
Merged

Compiled figure updates #69

merged 16 commits into from
Feb 28, 2024

Conversation

sjspielman
Copy link
Member

Closes #66
Closes #67

This PR updates the compiled versions of Fig 2 and S2:

Figure 2

I broke down panel B into panels B-G and updated the compiled figure. To improve the alignment in the compiled figure, I also separated out the final panel G, which was a little too tall in the previous compilation to easily place the panel label. This is now exported as its own PDF panel.
As such:

  • figures/pdfs/Fig2B_mini-qc-plots.pdf is now gone
  • Instead we now have figures/pdfs/Fig2B-F_mini-qc-plots.pdf and figures/pdfs/Fig2G_mini-qc-hvgs.pdf
    • Associated script updates in scripts/Fig2B-G_qc-plots.R

Figure S2

I broke down panel B into panels B-D and updated the compiled figure.

  • figures/pngs/FigS2B_adt-plots.png is now named figures/pngs/FigS2B-D_adt-plots.png
    • associated script change in scripts/FigS2B-D_adt-plots.R

The scripts/README.md is also updated accordingly.

Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I opened the pdf in photoshop locally the font is still Helvetica for the mini panels. Can you change it back to Arial please?

scripts/README.md Outdated Show resolved Hide resolved
@sjspielman
Copy link
Member Author

Arial-ified, great catch!!

Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sjspielman sjspielman merged commit 9d136f0 into main Feb 28, 2024
@sjspielman sjspielman deleted the sjspielman/more-panels branch February 28, 2024 21:10
@sjspielman sjspielman mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants