Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove linked directories from creation #826

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Conversation

jashapiro
Copy link
Member

When creating the skel directory for training, I ran into trouble where some of the directories that were created were also ones that were meant to be linked, which does not work. This change should fix that. I don't think we need to re-release the 2024-december tag, as I am fixing this manually in the skel

@jashapiro jashapiro requested a review from sjspielman December 4, 2024 22:57
Copy link
Member

@sjspielman sjspielman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10/10 name for this PR

#! /bin/bash
#!/bin/bash

set -euo pipefail
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jashapiro jashapiro merged commit e139c88 into master Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants