Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add LightAssembly class #1240

Open
wants to merge 1 commit into
base: release-v2.0.0
Choose a base branch
from

Conversation

dbirman
Copy link
Member

@dbirman dbirman commented Jan 16, 2025

This PR adds a LightAssembly class to a allow lights to be combined with a lens. It's possible other devices (filter?) should be allowed in a light assembly as well?

@dbirman dbirman requested a review from saskiad January 16, 2025 03:20
@dbirman dbirman linked an issue Jan 16, 2025 that may be closed by this pull request
@dbirman dbirman marked this pull request as ready for review January 17, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.0] Edge case with light and lenses attached together
1 participant