Copter: Allow CH6 tuning to change loiter speed #14188
Merged
+47
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rishabsingh3003 Need a rebase, apart from that I think this is good to go. |
|
@rishabsingh3003 bump on that rebase ;) |
|
I've rebased this. |
peterbarker
force-pushed
the
loit_tuning_knob
branch
from
7198d52 to
463d44b
Compare
peterbarker
force-pushed
the
loit_tuning_knob
branch
from
463d44b to
843b20f
Compare
|
I've tested this in SITL and it works as expected. |
|
@rmackay9 need your review |
peterbarker
force-pushed
the
loit_tuning_knob
branch
from
843b20f to
d0badf8
Compare
|
I've rebased this again and written an autotest for it: |
peterbarker
force-pushed
the
loit_tuning_knob
branch
from
d0badf8 to
8f3ba7f
Compare
peterbarker
force-pushed
the
loit_tuning_knob
branch
from
8f3ba7f to
c463c79
Compare
rmackay9
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been requested a few times in the past as well as in #9782.
This has been tested on SITL(incremented channel 6 by 100 every few seconds), and works well:
Can't test it on actual copter due to lockdown.
Looking forward to any improvements that can be suggested!
Fixes #9782