Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_HAL_ChibiOS: remove setting HAL_USE_UART to false #29016

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peterbarker
Copy link
Contributor

this is the default

Board           AP_Periph
Here4AP         *
Hitec-Airspeed  *
HitecMosaic     *
f103-GPS        *
f303-GPS        *
f303-MatekGPS   *

@tpwrules
Copy link
Contributor

tpwrules commented Jan 6, 2025

Assuming this is good if CI passes. Always like less lines.

Worth attacking the other related looking ones in the same PR?

  • empty SERIAL_ORDER
  • define HAL_NO_UARTDRIVER TRUE
  • define HAL_USE_SERIAL FALSE

@peterbarker
Copy link
Contributor Author

Assuming this is good if CI passes. Always like less lines.

Worth attacking the other related looking ones in the same PR?

* empty `SERIAL_ORDER`

* `define HAL_NO_UARTDRIVER TRUE`

* `define HAL_USE_SERIAL FALSE`

Yes, they're worth looking at. The first is likely to be a script problem, just a little but of python work.

I'm working on the second (https://github.com/peterbarker/ardupilot/tree/pr/HAL_NO_UARTDRIVER-usage)

Had a glance at the third earlier today and scratched my head a little...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants