ArduPlane: add climb before turn to AUTOLAND #29142
Open
+64
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtuxworth
reviewed
Jan 25, 2025
timtuxworth
reviewed
Jan 25, 2025
timtuxworth
suggested changes
Jan 25, 2025
IamPete1
reviewed
Jan 26, 2025
Hwurzburg
force-pushed
the
autoland_options_variation
branch
from
388f4c8 to
f29f06d
Compare
tridge
requested changes
Jan 28, 2025
| @@ -152,14 +167,41 @@ bool ModeAutoLand::_enter() | |||
| void ModeAutoLand::update() | |||
| { | |||
| plane.calc_nav_roll(); | |||
|
|
|||
| // check if initial climb before turn altitude has been reached | |||
| const float altitude = plane.relative_ground_altitude(false,false); | |||
There was a problem hiding this comment.
why is this an above home alt? why not use the terrain alt if available?
| // @User: Standard | ||
| AP_GROUPINFO("OPTIONS", 4, ModeAutoLand, options, 0), | ||
|
|
||
| // @Param: CLIMB | ||
| // @DisplayName: Climb before turning altitude | ||
| // @Description: Vehicle will climb with limited turn ability (LEVEL_ROLL_LIMIT) upon mode entry to this altitude, before proceeding to loiter-to-alt and landing legs. If a value less than AUTOLAND_WP_ALT is entered, AUTOLAND_WP_ALT will be used. |
There was a problem hiding this comment.
we need to specify what type of altitude it is using
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate to #29135
After test flying using a TX GCS to change climb to altitudes, I agree with Tim that this is easier to use then options in #29135...and it actually uses less flash so I am closing #29135