Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCS_MAVLink: correct resetting of parity after passthhru is done #29169

Merged

Conversation

peterbarker
Copy link
Contributor

@peterbarker peterbarker commented Jan 29, 2025

this might have worked if parity1 and parity2 were static values - but theyr're not. I'm guessing the code evolved

../../libraries/GCS_MAVLink/GCS_Common.cpp:6847:29: warning: Although the value stored to 'parity1' is used in the enclosing expression, the value is never actually read from 'parity1' [deadcode.DeadStores]
        _passthru.parity1 = parity1 = _passthru.port1->get_parity();
                            ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../libraries/GCS_MAVLink/GCS_Common.cpp:6848:29: warning: Although the value stored to 'parity2' is used in the enclosing expression, the value is never actually read from 'parity2' [deadcode.DeadStores]
        _passthru.parity2 = parity2 = _passthru.port2->get_parity();
                            ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

this might have worked if parity1 and parity2 were static values - but theyr're not.  I'm guessing the code evolved
@peterbarker peterbarker merged commit 9bfba32 into ArduPilot:master Jan 29, 2025
100 checks passed
@peterbarker peterbarker deleted the pr/gcs-restore-parity-fixes branch January 29, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Pending
Development

Successfully merging this pull request may close these issues.

2 participants