Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create and use AP_PERIPH_RPM_ENABLED and AP_PERIPH_RPM_STREAM_ENABLED #29216

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Create and use AP_PERIPH_RPM_ENABLED and AP_PERIPH_RPM_STREAM_ENABLED #29216

wants to merge 3 commits into from
+41 −20

Conversation

shiv-tyagi
Copy link
Contributor

Part of HAL_PERIPH_XX_ENABLE renaming series.

Follows #29203

@shiv-tyagi shiv-tyagi marked this pull request as draft February 3, 2025 13:03
@shiv-tyagi shiv-tyagi force-pushed the ap-periph-rpm branch 5 times, most recently from 1d26b8d to 85c80c9 Compare February 3, 2025 15:49
peterbarker
peterbarker reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why AP_PERIPH_RPM_STREAM_ENABLED requires AP_PERIPH_RPM_ENABLED?

ie. are they two separate features which both happen to require AP_RPM_ENABLED?

@shiv-tyagi
AP_HAL_ChibiOS: create and use AP_PERIPH_RPM_ENABLED and AP_PERIPH_RP…
4d759a3 
…M_STREAM_ENABLED defines for HAL_PERIPH_ENABLE_RPM and HAL_PERIPH_ENABLE_RPM_STREAM
@shiv-tyagi
Copy link
Contributor Author

shiv-tyagi commented Feb 4, 2025 •
edited
Loading

Any idea why AP_PERIPH_RPM_STREAM_ENABLED requires AP_PERIPH_RPM_ENABLED?

I have no idea I'm afraid. This was pre-existing. Please see this and this.

@shiv-tyagi shiv-tyagi marked this pull request as ready for review February 4, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbarker peterbarker peterbarker left review comments

Assignees
No one assigned
Labels
DevCallTopic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shiv-tyagi @peterbarker