Fix clang compiler warnings #29238
Merged
Fix clang compiler warnings #29238
+12
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
../../libraries/AP_Airspeed/AP_Airspeed_AUAV.h:68:11: warning: private field 'pressure_abs_L' is not used [-Wunused-private-field] 68 | float pressure_abs_L;
In file included from ../../libraries/AP_HAL_SITL/RCInput.cpp:6:
../../libraries/AP_HAL_SITL/RCInput.h:22:17: warning: private field '_sitlState' is not used [-Wunused-private-field]
22 | SITL_State *_sitlState;
| ^
../../libraries/AP_HAL_SITL/RCInput.h:23:10: warning: private field 'using_rc_protocol' is not used [-Wunused-private-field]
23 | bool using_rc_protocol;
| ^
../../libraries/AP_RangeFinder/AP_RangeFinder_LightWareI2C.cpp:158:105: warning: argument 'reply' of type 'char[15]' with mismatched bound [-Warray-parameter]
158 | void AP_RangeFinder_LightWareI2C::sf20_get_version(const char* send_msg, const char *reply_prefix, char reply[15])
| ^
../../libraries/AP_RangeFinder/AP_RangeFinder_LightWareI2C.h:47:80: note: previously declared as 'char[5]' here
47 | void sf20_get_version(const char* send_msg, const char *reply_prefix, char reply[5]);
| ^
tridge
approved these changes
Feb 11, 2025
|
ok to merge once testing scripting restart with i2c script |
|
scripting restart worked just fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unused variables and wrong abs function used.
CI-tested only. And locally for compilation...
.... also now stops scripting using OwnPtr for i2c devices; this was tested on a ZeroOneX6 with an RM3100 and an example script which triggers a self-test on the device.