GCS_Common: better handle negative intervals #29243
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treat all negative interval values like -1.
|
GCSs shouldn't send request for negative rates, but this came about because this Mission Planner bug I introduced: ArduPilot/MissionPlanner#3487 |
|
I'm not so sure the default should be "stop sending" messages. Perhaps invalid values should be ignored? |
peterbarker
requested changes
Feb 7, 2025
| @@ -3127,7 +3127,7 @@ MAV_RESULT GCS_MAVLINK::set_message_interval(uint32_t msg_id, int32_t interval_u | |||
| // at. | |||
| interval_ms = 0; | |||
| } | |||
| } else if (interval_us == -1) { | |||
| } else if (interval_us < 0) { | |||
There was a problem hiding this comment.
Suggested change
| } else if (interval_us < 0) { | |
| } else if (interval_us == -1) { |
| @@ -3127,7 +3127,7 @@ MAV_RESULT GCS_MAVLINK::set_message_interval(uint32_t msg_id, int32_t interval_u | |||
| // at. | |||
| interval_ms = 0; | |||
| } | |||
| } else if (interval_us == -1) { | |||
| } else if (interval_us < 0) { | |||
| // minus-one is "stop sending" | |||
| interval_ms = 0; | |||
| } else if (interval_us < 1000) { | |||
There was a problem hiding this comment.
Suggested change
| } else if (interval_us < 1000) { | |
| } else if (interval_us < 0) { | |
| return MAV_RESULT_DENIED; | |
| } else if (interval_us < 1000) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat all negative interval values like -1. This is preferable to the current behavior, where we treat those like 1000Hz requests.