refactor(cardinal): consolidate test components #178
ci-go.yaml
on: pull_request
Lint (go)
1m 5s
Unit Test (go)
55s
Validate (Swagger)
33s
E2E (Nakama)
1m 20s
Annotations
6 errors and 3 warnings
Unit Test (go)
Process completed with exit code 2.
|
Lint (go):
cardinal/testsuite/components.go#L164
string `test` has 3 occurrences, make it a constant (goconst)
|
Lint (go):
cardinal/testsuite/utils.go#L137
comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
|
Lint (go):
cardinal/testsuite/utils.go#L122
Magic number: 5, in <argument> detected (mnd)
|
Lint (go):
cardinal/testsuite/utils.go#L127
Magic number: 100, in <argument> detected (mnd)
|
Lint (go)
issues found
|
Validate (Swagger)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Validate (Swagger)
Failed to restore: "/usr/bin/tar" failed with error: The process '/usr/bin/tar' failed with exit code 2
|
Lint (go):
cardinal/testsuite/components_test.go#L306
unused-parameter: parameter 'entityID' seems to be unused, consider removing or renaming it as _ (revive)
|