Upgrade dependencies #253
Upgrade dependencies #253
Conversation
|
I'm going to test this in |
package.json
Outdated
| "test": "npm run lint && npm run test:bin && npm run test:server && npm run test:browser", | ||
| "test:bin": "mocha './test/bin/**/*.test.js'", | ||
| "test:browser": "npm run test:browser:other && npm run test:browser:ctor", | ||
| "test:browser:other": "npx d2l-test-runner --files './test/browser/**/*.test.js'", | ||
| "test:browser:other": "npx d2l-test-runner --files ./test/browser/**/*.test.js", |
There was a problem hiding this comment.
What was the issue with quotes for you? This can cause issues on POSIX system because it tries to pre-fill the wildcard and send in an array.
There was a problem hiding this comment.
Error was:
Error: Could not find any test files with pattern(s): './test/browser/**/*.test.js',!**/node_modules/**/*
at createTestSessions (C:\Desire2Learn\Instances\BrightspaceUI\testing\node_modules\@web\test-runner-core\dist\runner\createSessionGroups.js:55:19)
at new TestRunner (C:\Desire2Learn\Instances\BrightspaceUI\testing\node_modules\@web\test-runner-core\dist\runner\TestRunner.js:32:115)
at Object.startTestRunner [as start] (C:\Desire2Learn\Instances\BrightspaceUI\testing\node_modules\@web\test-runner\dist\startTestRunner.js:24:24)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async runTests (file:///C:/Desire2Learn/Instances/BrightspaceUI/testing/bin/d2l-test-runner.js:47:2)
Maybe we need to trim the quotes off in the client?
There was a problem hiding this comment.
Was that locally or in CI? I think I saw @dlockhart do this another way somewhere but I can't remember what it was. Escape the *, maybe?
There was a problem hiding this comment.
Locally. We ran into something similar here, but that was a totally different library. Seems odd. BrightspaceUI/core#4222
There was a problem hiding this comment.
Hmm, not recalling "the other way".
There was a problem hiding this comment.
Looks like escaped quotes work. Still not sure what exactly changed, but I assume this is what could be used to get around the POSIX system issue?
|
This causes no vdiff changes in |
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
With these changes:
@brightspace-ui/testingis on node 18).--filespiece doesn't work (from a quick search, I don't think anyone is doing this except this repo)nodeResolvein the dev server for the report{ exportConditions: ['default'] }