Bug fix: reminder service not using config #8369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehansen
requested review from
DanielSass,
emyl3,
mpbrown,
DavidMcClatchey and
bobbywells52
|
emyl3
approved these changes
Dec 24, 2024
mpbrown
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACKEND PULL REQUEST
Related Issue
Discovered while I was reviewing #8315
Context: This service sends reminder emails every day to recently created orgs that have not ID verified. It was originally disabled in the non-prod envs but in this PR almost 2 years ago I accidentally broke that part so it's been not using the config property correctly since then
Changes Proposed
use the
@Valueannotation to get the property instead of@ConditionalOnProperty, which is meant to be used for bean registrationTesting
Tested in
dev5by deploying merethe/fix-reminderservice-config-TEST and checked app insights to see it's hitting the log for skippingCan also be tested locally by tweaking the cron and checking the logs