Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pyjson #339

Closed
wants to merge 57 commits into from
Closed

Feature/pyjson #339

wants to merge 57 commits into from

Conversation

ahouseholder
Copy link
Contributor

@ahouseholder ahouseholder commented Oct 12, 2023

Reopening to keep the PR active (#328 closed automatically when I was messing with the branch), but
(a) please don't push to this branch directly while it's in draft mode, and
(b) there are a number of comments in the thread of #328 that should be separate issues entirely.
This PR is about getting the python stuff in place. Content changes are out of scope for this PR.

s/option/value/
s/label/name/
add namespace
Squashed commits:
[83a77f3] objects instead of classes
[5a59166] objects instead of classes
[7b3713a] objects instead of classes
[073ca1f] objects instead of classes
[566d353] objects instead of classes
[f4d8c4d] objects instead of classes
[4c88f78] objects instead of classes
[ab2ae3e] objects instead of classes
[f79af19] objects instead of classes
[70409e4] objects instead of classes
[9e8dbb2] objects instead of classes
[4681eb0] objects instead of classes
[9d9f7e7] objects instead of classes
[8a01597] objects instead of classes
[73d60ef] objects instead of classes
[f893a71] objects instead of classes
[40003b0] objects instead of classes
[7bf8692] objects instead of classes
[bbec973] objects instead of classes
[838fbf4] refactor imports
[c81545c] copy objects instead of new classes
[0d4d8ee] add default version 0.0.0
[bd0b9d9] add cvss v1, v2, v3
[700d049] rename classes, clean up mixins
[10884aa] add namespaced mixin class
[5a83e0c] add s/option/value/
[42f2110] add docstrings
@ahouseholder ahouseholder self-assigned this Oct 12, 2023
@sei-vsarvepalli
Copy link
Contributor

sei-vsarvepalli commented Oct 12, 2023

The relative path is what is from the root of the repository itself I think.
https://github.com/ahouseholder/SSVC/blob/31de409580775cbc65cf1e5271efea9b436d09e1/src/test/test_schema.py#L12

should be more like "data/schema/Decision_Point.schema.json" like that. Also the ID field inside the schema needs to be updated to reflect the new location. These two lines also need to be updated.

https://github.com/ahouseholder/SSVC/blob/31de409580775cbc65cf1e5271efea9b436d09e1/data/schema/Decision_Point.schema.json#L4

https://github.com/ahouseholder/SSVC/blob/31de409580775cbc65cf1e5271efea9b436d09e1/data/schema/Decision_Point_Group.schema.json#L4

@ahouseholder
Copy link
Contributor Author

I will be withdrawing this PR once I've chunked it up into a series of smaller PRs.

So far that includes:

There will be a few more. I'll try to remember to mention this PR when I submit them.

@ahouseholder
Copy link
Contributor Author

@ahouseholder
Copy link
Contributor Author

All of the subsequent fragments of this PR have been merged, so this one is no longer needed as a placeholder.

@ahouseholder ahouseholder deleted the feature/pyjson branch November 17, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants