Add SSVC python module #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SSVC v1, v2, v2.1
ahouseholder
requested review from
sei-vsarvepalli and
cgyarbrough
as code owners
sei-vsarvepalli
requested changes
Oct 16, 2023
sei-vsarvepalli
approved these changes
Oct 16, 2023
jeroenh
pushed a commit
to jeroenh/SSVC
that referenced
this pull request
Oct 18, 2023
* add new json schemas for decision points and dp groups * add ssvc module to represent existing decision points and groups for SSVC v1, v2, v2.1 * add decision point group schema validation test * add doc for csv analyzer * Update Decision_Point.schema.json change ID url to https://github.com/CERTCC/SSVC/tree/main/data/schema/... * Update Decision_Point_Group.schema.json change id url to https://github.com/CERTCC/SSVC/tree/main/data/schema/... --------- Co-authored-by: Vijay Sarvepalli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Represents SSVC v1, v2, v2.1 decision point groups and decision points as python dataclasses using the dataclasses-json module to allow for json format data roundtrip.
Includes schema and schema validation tests.
Note: this branch includes the schemas defined in PR #340, so we should resolve that PR before this one.
This PR is part 1 of N (where N is probably 2-4) that breaks up #339.
Future PRs will likely address #319 and #330, as well as add generated documentation based on the modules in this PR. I am deliberately keeping this PR limited to python changes necessary to implement a resolution to #325