-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP implement proof of concept for single top-level presenter factory #368
Open
aaron-plahn
wants to merge
30
commits into
integration
Choose a base branch
from
single-presenter-factory
base: integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#333) * WIP modify image view components * WIP fixed lint errors --------- Co-authored-by: yaanahuu2 <[email protected]>
…plement in presenters (#330) * WIP added custom heading styles to theme and refactored presenters * WIP addressed test issues --------- Co-authored-by: yaanahuu2 <[email protected]>
* feat(api): support full episodes model for playlists * WIP: index presenter for playlist * WIP: playlist presenter * WIP playlist-index-presenter * feat(coscrad-frontend): add index filters for playlists * fix(coscrad): fix minor issues with playlists post rebase * fix(coscrad-frontend): removed console.logs --------- Co-authored-by: Blake Sellars <[email protected]>
…323) * WIP - term of the day component * WIP - changes from PR 323 * WIP - added term-of-the-day component * WIP - updated term of the day with prettier * Use term of day container in home * complete data flow for term of the day * style(coscrad-frontend): add mui styled component for term of the day * style(coscrad-frontend): update styled component from suggestions on PR --------- Co-authored-by: Aaron Plahn <[email protected]>
* refactor(api): move router to data API * Add test coverage for configurable routes * test(coscrad-frontend): add test for dynamic nav menu builder * test(coscrad-frontend): add unit test for build routes * refactor based on PR (#337) * test(coscrad-frontend): fix dynamic routes test for spatial features and playlists
…orms (#339) * style(coscrad-frontend): update styling for vocabulary list detail presenter and forms * style(coscrad-frontend): made changes from suggestions on PR * style(coscrad-frontend): changed format to have components as children of the parent
…#345) * WIP removed css import from presenters * WIP address review comments * WIP fixed video-detail test --------- Co-authored-by: yaanahuu2 <[email protected]>
…347) * WIP remove custom css fix marker shadow * WIP move leaflet css import --------- Co-authored-by: yaanahuu2 <[email protected]>
…#344) * WIP remove .css import * WIP fix object fit on full view photograph * WIP add testids to thumbnail presenters --------- Co-authored-by: yaanahuu2 <[email protected]>
…eature index and thumbnail (#348) * WIP modify thumbnail and add full-view presenter * start cypress test * WIP revert changed test data files * WIP add cypress test of map index-to-detail flow * WIP revert resource-nav-link * WIP remote autogenerated cypress directory from root * WIP fixing cypress test * WIP fix cypress test of spatial features href * WIP remove custom cypress command --------- Co-authored-by: yaanahuu2 <[email protected]>
* feat(coscrad-frontend): support a loading component with a configurable message * style(coscrad-frontend): changes based off suggestions from PR * feat(coscrad-frontend): added a default loading message
#351) * WIP removed css imports and refactored table display * WIP fix style declaration in table * WIP changed TableContainer name * WIP fix table cell font-size * WIP updated snapshots --------- Co-authored-by: yaanahuu2 <[email protected]>
…nces (#336) * WIP update bibliograhic reference presenters * WIP added multiple property presenter * WIP removed card from resource detail full view * WIP updated bibliographic reference full view presenters * WIP added comma separated list component * WIP correct filename * WIP fixed file path * WIP started test and comma component * WIP add cypress test for bibliographic presenter * WIP created test for multiple property presenter * WIP make thumbnail link arrow primary variant * WIP fixed lint errors * WIP string shortener * WIP fixed single property presenter grid * WIP update thumbnail presenters with type * WIP add note to thumbnail presenters * WIP add id info icon * WIP address pr comments * WIP add bibliographic edge connection test data * WIP address testing issues --------- Co-authored-by: yaanahuu2 <[email protected]>
* WIP update term presenter and remove CSS * WIP delete generic presenter css file * WIP fix tests and multiple-property-presenter * refactor(coscrad-frontend): tighten up multi-property presenter prop types * WIP add single optional property presenter --------- Co-authored-by: yaanahuu2 <[email protected]> Co-authored-by: Aaron Plahn <[email protected]>
* WIP add copy button and dialog * WIP finalize modal text * WIP change copy icon alignment * WIP fix presenter * WIP cypress copy test * WIP add two buttons for copying id * WIP create re-usable id copy button component * WIP correct text in copy modal * WIP add clipboard permissions to cypress test * WIP remove cypress clipboard command * test(coscrad-frontend): refactor copy ID info component test * test(coscrad-frontend): consolidate chainable interface --------- Co-authored-by: yaanahuu2 <[email protected]> Co-authored-by: Aaron Plahn <[email protected]>
* WIP: building audio panel for index views * WIP: make changes from PR * WIP finish playlist detail presenter and index-to-detail flow * WIP: converted audio-panel to explicit return * fix issues after rebase * fix: type error * test(api): update stale snapshots --------- Co-authored-by: Aaron Plahn <[email protected]>
* WIP Introduce domain-dump CLI command * feat(cli): introduce first CLI command: domain-dump * fix a couple Sonar cloud issues * Add error handling to CLI bootstrap call * fix issue with test output data path * refactor basedon PR (#360) * use hard-wired test datafile name * tweak test file output name
* move builds to DigitalOcean cloud * add logging to troubleshoot missing deps * add additional logging * use nodejs plugin * add cli build
Co-authored-by: yaanahuu2 <[email protected]>
* feat(cli): introduce restore cli command * test(api): remove obsolete snapshots * refactor based on PR (#365)
* WIP remove coscrad main content container * WIP fixed tests and lint --------- Co-authored-by: yaanahuu2 <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
aaron-plahn
force-pushed
the
integration
branch
from
September 20, 2023 17:37
4b79469
to
ac52327
Compare
aaron-plahn
force-pushed
the
integration
branch
from
October 24, 2023 21:31
45ef73a
to
9411033
Compare
aaron-plahn
force-pushed
the
integration
branch
from
November 23, 2023 17:16
05c3b03
to
82386bc
Compare
aaron-plahn
force-pushed
the
integration
branch
2 times, most recently
from
December 6, 2023 16:17
0d138d6
to
a22c1f4
Compare
aaron-plahn
force-pushed
the
integration
branch
3 times, most recently
from
December 21, 2023 15:33
0507112
to
bc02871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.