Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom highlight color in tabs #1557

Closed
wants to merge 11 commits into from
Closed

Custom highlight color in tabs #1557

wants to merge 11 commits into from

Conversation

2qar
Copy link
Contributor

@2qar 2qar commented Feb 16, 2020

Closes #1543
Tabs will highlight whatever color is set for that highlight instead of highlighting red.

Example:
Highlight

@fourtf
Copy link
Member

fourtf commented Feb 16, 2020

what happens if there are multiple highlights?

@2qar
Copy link
Contributor Author

2qar commented Feb 16, 2020

The color of the tab will be whichever highlight happened last. Should there be a priority (eg. username > highlight phrases)?

@fourtf
Copy link
Member

fourtf commented Feb 16, 2020

I'm not sure, perhaps the order of the highlights? Maybe it would also be possible to highlight the tab using multiple colors. None of this is really thought out, just some ideas.

@leon-richardt
Copy link
Collaborator

I'm not sure, perhaps the order of the highlights?

That would be nice in combination with #1542. 😄

@2qar
Copy link
Contributor Author

2qar commented Feb 16, 2020

Maybe it would also be possible to highlight the tab using multiple colors.

Maybe split up like this?
Highlight split

@fourtf
Copy link
Member

fourtf commented Feb 20, 2020

That's what I was thinking off but I'm not sure if it's the right way to go

@2qar
Copy link
Contributor Author

2qar commented Feb 24, 2020

Sorry for the slow response, here's my ideas so far:

  • Leaving it and adding Allow reordering elements in list settings #1542 would keep it simple, but won't represent all highlights in that tab
  • Splitting the colored part would represent more highlights, but looks kinda ugly and would get cluttered fast
  • Flash between the different highlight colors? (probably distracting)

Maybe there could be a setting for this, maybe I'm just overcomplicating it, idk. I think keeping it one color is the right way to go from a visual standpoint.

pajlada
pajlada requested changes Mar 14, 2020
View reviewed changes
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signals tabHighlightRequested and tabHighlightColorRequested are both called at the same time, and modify similar code. The tabHighlightColorRequested signal should be removed, and another argument should just be added to the tabHighlightRequested signal for the Color.

Other than that, and pending #1542 , I think the feature is nice as is. 👍

@2qar
Remove tabHighlightColorRequested signal
2a9b8e1 
Moved the functionality to tabHighlightRequested instead of having two
signals that modify similar things
@2qar 2qar requested a review from pajlada March 14, 2020 19:42
pajlada
pajlada requested changes Mar 15, 2020
View reviewed changes
src/widgets/splits/SplitContainer.cpp Outdated Show resolved Hide resolved
@2qar
Check tabHighlightRequested color in safer scope
50b2dec 
The little bit that set the tab's highlight color never checked whether
the tab was a nullptr or not
i'm a little silly
@2qar 2qar requested a review from pajlada March 15, 2020 14:21
@pajlada pajlada self-assigned this Aug 9, 2020
@apa420 apa420 mentioned this pull request Sep 25, 2020
Closed
@fourtf fourtf requested review from fourtf and removed request for pajlada September 26, 2020 13:21
@fourtf
Copy link
Member

fourtf commented Sep 26, 2020

I'll consider if this should be added.

@pajlada pajlada assigned fourtf and unassigned pajlada Oct 11, 2020
@ALazyMeme
Copy link
Collaborator

I'll consider if this should be added.

Have you considered yet?

@ALazyMeme
Copy link
Collaborator

:/ ...

@zneix zneix mentioned this pull request Apr 30, 2021
Closed
@jupjohn
Copy link
Contributor

jupjohn commented Jul 10, 2021

@ALazyMeme he's still considering :)

@Felanbird
Copy link
Collaborator

@fourtf It's been just north of 1 year and 2 weeks, have you made a decision?

@xHeaveny
Copy link
Contributor

time to revive this
image

@jupjohn
Copy link
Contributor

jupjohn commented Aug 10, 2022

@fourtf this is beyond stale now, have you made a decision?

@anqueue
Copy link
Contributor

anqueue commented Aug 27, 2022

Is there anyone against this change? This PR has been open for years now.

Since GitHub issues doesn't have the polls feature that the discussions have, react with 👍 if you are for this change and 👎 if you are against it.

@Mm2PL
Copy link
Collaborator

Mm2PL commented Aug 27, 2022

@fourtf, @pajlada, @zneix, it's about time to decide if this PR is good or one that we should close.

pajlada added 3 commits August 28, 2022 12:35
@pajlada
Merge remote-tracking branch 'origin/master' into custom-highlight-co…
d4c1ef5 
…lor-tabs
@pajlada
Change fallback highlight color
16042e7 
This makes the color look almost identical in highlights, but completely identical in tab highlights
@pajlada
Remove unneccesary dereference of the highlightcolor
8d9617d
@Felanbird
Copy link
Collaborator

We missed 2 years 🎆 🎈 - I'll try to remember next year that Sept 26th is the anniversary

@Infinitay
Copy link
Contributor

Do I dare suggest for an option for channels you are subscribed in to be highlighted?

@fourtf
Copy link
Member

fourtf commented Aug 26, 2024

I wasn't aware that this was still open. Looks good to me 👍

@fourtf fourtf removed their assignment Aug 26, 2024
@pajlada
Copy link
Member

pajlada commented Aug 26, 2024

I'll take a look at this and how it fits in the current code, and solve the merge conflicts where applicable

@pajlada pajlada self-assigned this Aug 26, 2024
@pajlada pajlada mentioned this pull request Aug 31, 2024
Draft
@pajlada
Copy link
Member

pajlada commented Aug 31, 2024

Closing in favour of #5579

@pajlada pajlada closed this Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajlada pajlada pajlada requested changes

@fourtf fourtf Awaiting requested review from fourtf

Assignees

@pajlada pajlada

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use custom highlight colors in tabs