Custom highlight color in tabs #5579
Draft
+44
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I put it there last night and I think I forgot about it :)
Moved the functionality to tabHighlightRequested instead of having two signals that modify similar things
The little bit that set the tab's highlight color never checked whether the tab was a nullptr or not i'm a little silly
This makes the color look almost identical in highlights, but completely identical in tab highlights
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -397,6 +398,15 @@ bool NotebookTab::hasHighlightsEnabled() const | |||
| return this->highlightEnabled_; | |||
| } | |||
|
|
|||
| void NotebookTab::setHighlightColor(std::shared_ptr<QColor> color) | |||
There was a problem hiding this comment.
warning: the parameter 'color' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Suggested change
| void NotebookTab::setHighlightColor(std::shared_ptr<QColor> color) | |
| void NotebookTab::setHighlightColor(const std::shared_ptr<QColor>& color) |
src/widgets/helper/NotebookTab.hpp:67:
- void setHighlightColor(std::shared_ptr<QColor> color);
+ void setHighlightColor(const std::shared_ptr<QColor>& color);| }); | ||
| conns.managedConnect( | ||
| split->getChannelView().tabHighlightRequested, | ||
| [this](HighlightState state, std::shared_ptr<QColor> color) { |
There was a problem hiding this comment.
warning: the parameter 'color' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Suggested change
| [this](HighlightState state, std::shared_ptr<QColor> color) { | |
| [this](HighlightState state, const std::shared_ptr<QColor>& color) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #1557 authored by @2qar