-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom highlight color in tabs #5579
Draft
pajlada
wants to merge
12
commits into
master
Choose a base branch
from
feat/custom-highlight-color-tabs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+44
−10
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cd2ab5e
flash highlight color instead of red in channel tab
2qar b38bfd4
fix tab highlighting when focused
2qar 5e25722
remove pointless condition in setHighlightState
2qar e9bebfe
clean up setting tab line color
2qar 2a9b8e1
Remove tabHighlightColorRequested signal
2qar 50b2dec
Check tabHighlightRequested color in safer scope
2qar 2d93cee
Merge branch 'master' into custom-highlight-color-tabs
pajlada 5b2341a
Merge branch 'master' into custom-highlight-color-tabs
pajlada d4c1ef5
Merge remote-tracking branch 'origin/master' into custom-highlight-co…
pajlada 16042e7
Change fallback highlight color
pajlada 8d9617d
Remove unneccesary dereference of the highlightcolor
pajlada 439d21d
Merge remote-tracking branch 'origin/master' into custom-highlight-co…
pajlada File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -213,13 +213,19 @@ void SplitContainer::addSplit(Split *split) | |||||
|
||||||
auto &&conns = this->connectionsPerSplit_[split]; | ||||||
|
||||||
conns.managedConnect(split->getChannelView().tabHighlightRequested, | ||||||
[this](HighlightState state) { | ||||||
if (this->tab_ != nullptr) | ||||||
{ | ||||||
this->tab_->setHighlightState(state); | ||||||
} | ||||||
}); | ||||||
conns.managedConnect( | ||||||
split->getChannelView().tabHighlightRequested, | ||||||
[this](HighlightState state, std::shared_ptr<QColor> color) { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: the parameter 'color' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Suggested change
|
||||||
if (this->tab_ != nullptr) | ||||||
{ | ||||||
this->tab_->setHighlightState(state); | ||||||
|
||||||
if (color != nullptr) | ||||||
{ | ||||||
this->tab_->setHighlightColor(color); | ||||||
} | ||||||
} | ||||||
}); | ||||||
|
||||||
conns.managedConnect(split->getChannelView().liveStatusChanged, [this]() { | ||||||
this->refreshTabLiveStatus(); | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: the parameter 'color' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
src/widgets/helper/NotebookTab.hpp:67: