Fix CefDisplayHandler.onFullscreenModeChange name (see chromiumembedd…

…ed#239) Method names should follow Java naming conventions.
CinemaMod · Mar 20, 2024 · ea25085 · ea25085
1 parent 0b8e42e
commit ea25085
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/java/org/cef/CefClient.java b/java/org/cef/CefClient.java
@@ -312,9 +312,9 @@ public void onTitleChange(CefBrowser browser, String title) {
     }
 
     @Override
-    public void OnFullscreenModeChange(CefBrowser browser, boolean fullscreen) {
+    public void onFullscreenModeChange(CefBrowser browser, boolean fullscreen) {
         if (displayHandler_ != null && browser != null)
-            displayHandler_.OnFullscreenModeChange(browser, fullscreen);
+            displayHandler_.onFullscreenModeChange(browser, fullscreen);
     }
 
     @Override

diff --git a/java/org/cef/handler/CefDisplayHandler.java b/java/org/cef/handler/CefDisplayHandler.java
@@ -33,7 +33,7 @@ public interface CefDisplayHandler {
      * @param browser The browser generating the event.
      * @param fullscreen True if fullscreen mode is on.
      */
-    public void OnFullscreenModeChange(CefBrowser browser, boolean fullscreen);
+    public void onFullscreenModeChange(CefBrowser browser, boolean fullscreen);
 
     /**
      * About to display a tooltip.

diff --git a/java/org/cef/handler/CefDisplayHandlerAdapter.java b/java/org/cef/handler/CefDisplayHandlerAdapter.java
@@ -25,7 +25,7 @@ public void onTitleChange(CefBrowser browser, String title) {
     }
 
     @Override
-    public void OnFullscreenModeChange(CefBrowser browser, boolean fullscreen) {
+    public void onFullscreenModeChange(CefBrowser browser, boolean fullscreen) {
         return;
     }
 

diff --git a/java/tests/detailed/MainFrame.java b/java/tests/detailed/MainFrame.java
@@ -184,7 +184,7 @@ public void onStatusMessage(CefBrowser browser, String value) {
                 status_panel_.setStatusText(value);
             }
             @Override
-            public void OnFullscreenModeChange(CefBrowser browser, boolean fullscreen) {
+            public void onFullscreenModeChange(CefBrowser browser, boolean fullscreen) {
                 setBrowserFullscreen(fullscreen);
             }
         });

diff --git a/java/tests/simple/MainFrame.java b/java/tests/simple/MainFrame.java
@@ -133,7 +133,7 @@ public void onAddressChange(CefBrowser browser, CefFrame frame, String url) {
                 address_.setText(url);
             }
             @Override
-            public void OnFullscreenModeChange(CefBrowser browser, boolean fullscreen) {
+            public void onFullscreenModeChange(CefBrowser browser, boolean fullscreen) {
                 setBrowserFullscreen(fullscreen);
             }
         });

diff --git a/native/display_handler.cpp b/native/display_handler.cpp
@@ -119,7 +119,7 @@ void DisplayHandler::OnFullscreenModeChange(CefRefPtr<CefBrowser> browser,
     return;
 
   ScopedJNIBrowser jbrowser(env, browser);
-  JNI_CALL_VOID_METHOD(env, handle_, "OnFullscreenModeChange",
+  JNI_CALL_VOID_METHOD(env, handle_, "onFullscreenModeChange",
                        "(Lorg/cef/browser/CefBrowser;Z)V", jbrowser.get(),
                        (jboolean)fullscreen);
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -25,7 +25,7 @@ public void onTitleChange(CefBrowser browser, String title) { @@
         }
         @Override
-        public void OnFullscreenModeChange(CefBrowser browser, boolean fullscreen) {
+        public void onFullscreenModeChange(CefBrowser browser, boolean fullscreen) {
             return;
         }
@@ Expand Down @@