Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HKISD-268: get always current year in project card #239

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

saijaseppa
Copy link
Contributor

@saijaseppa saijaseppa commented Feb 13, 2025

  • Related UI-PR: HKISD-268: get always current year in project card infraohjelmointi-ui#322
  • Ticket: https://futurice.atlassian.net/jira/software/c/projects/HKISD/boards/62?selectedIssue=HKISD-268
  • Description
    • variable "startYear" is taken from planningView's year selector, and all sap values and current year's sap values are
      fetched from database to state based on that selected year.
    • In planning view we want to show sap values only for the year that is selected in year selector as start year for time line
    • In project card previously sap values were taken from state based on this start year. This was not wanted, since
      project card should show always current year's sap costs sum and total sum of sap costs and total sum of sap
      commitments, even if start year in planning view is something else than real current year.
  • Changes:
    • when fetching all sap values in App.ts, the year is set to be always current year, not the selected year from planning view
    • Backend now sends project's sap values for current year in project response when calling endpoint /project/{id} and those are shown in project card
  • Testing:
    • in dev we can test by checking values from tables sapCurrentYear and sapCosts and compare those to planning view's and project card's sap values
    • Locally if wanted, this can be tested by creating values in mentioned tables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant