Localize Terms of Use and Privacy Policy pages #471
Conversation
Chris dev 3
Chris dev 3
Merge branch 'master' of https://github.com/CodeForBoulder/upswyng in…
Co-authored-by: Jeremiah Tabb <[email protected]>
Co-authored-by: Jeremiah Tabb <[email protected]>
Chris dev
cjlynch278
requested review from
jacobvenable,
jollyjerr and
rhinodavid
as code owners
|
Deploy request for upswyng accepted. Accepted with commit 9448692 https://app.netlify.com/sites/upswyng/deploys/60935c2c07c6e900071a9b52 |
There was a problem hiding this comment.
Usually we aim for having a single PR per issue to separate concerns, but that's not a big deal.
There are a couple of small nits to address before merge, but I think this looks really good! 😄
I saw your note about having issues setting up the environment, so let me know if you would like help troubleshooting.
Co-authored-by: Jacob <[email protected]>
Co-authored-by: Jacob <[email protected]>
Fix translations
|
Hey @jacobvenable I'm pretty sure I integrated all of the changes that you had mentioned and also a changed the files that are calling the changed keys. I will definitely take you up on your offer to set up my dev environment. I'll try to ping you if we both happen to be online. |
This PR closes #461 and #462
What does this PR do?
Adds the translations for the Terms of Use and Privacy Policy pages
How does this PR make you feel? 🔗
I'm still new to this project so please carefully inspect my changes - I don't have my environment properly set up to test.
Additionally I added the translation keys/mappings for the pages in the packages/common/src/i18n/en.ts/es.ts files under the "About" category. I know this may be a tad misleading, but I thought I'd group the 3 pages together.