Fix dynamic lights intensity, cleanup

[VReaperV]

Cgame-side pr: Unvanquished/Unvanquished#3184
Dynamic light config update for weapon flash colours: UnvanquishedAssets/res-weapons_src.dpkdir#32

• NUKED the weird 4x dynamic light scaling
• NUKED the weird r_lightScale cvar, which is used for dynamic lights, but it's a cheat cvar and always set to 2.0, and essentially only used for dynamic lights spawned from movers
• NUKED RE_AddDynamicLightToSceneQ3A() and renamed RE_AddDynamicLightToSceneET() to RE_AddDynamicLightToScene() because they're essentially the same
• NUKED now unused trap_R_AddAdditiveLightToScene()
• NUKED light intensity/scale, which was only used to scale the light's colour, just multiply the colour earlier on instead
• Fixed some incorrect memory read before bounds check

Fixes #61:
hq-beta28:
Before:

After:

tremtest:
Before:

After:

[slipher]

Why don't we nuke the intensity argument? It seems to be redundant with just changing the r/g/b values.

[VReaperV]

Why don't we nuke the intensity argument? It seems to be redundant with just changing the r/g/b values.

Right, done now.

[slipher]

The forward lighting shader checks the sign of u_LightScale to check for inverse lights. These are said to be already broken, but it would be nice to set the scale to 1 or -1 to at least gesture at how it was supposed to work

[VReaperV]

scale is already removed there, so there's nothing to set.

[slipher]

I tested this branch vs. master and found the dynamic lights are not as bright. I guess if you deleted a factor of 8 of random scaling, you need to add that back in somewhere to get the same result?

Master:

This branch:

[VReaperV]

I tested this branch vs. master and found the dynamic lights are not as bright. I guess if you deleted a factor of 8 of random scaling, you need to add that back in somewhere to get the same result?

Master:

This branch:

I have created a PR in res-weapons repo for this: UnvanquishedAssets/res-weapons_src.dpkdir#32.

[DolceTriade]

tested ingame and feels good

[slipher]

There are some maps with particle systems with dynamic lights, so not everything can be made the same by only adjusting the game’s own assets.

Also there are some places where dynamic light intensities from config files are clamped to [0, 1] (yeah that’s stupid and shouldn’t be done), so that’s something we would need to watch out for if adjusting configs.

[VReaperV]

There are some maps with particle systems with dynamic lights, so not everything can be made the same by only adjusting the game’s own assets.

Which maps?

Also there are some places where dynamic light intensities from config files are clamped to [0, 1] (yeah that’s stupid and shouldn’t be done), so that’s something we would need to watch out for if adjusting configs.

Yes, that is particles and beams/trails. Those look fine though.

[slipher]

There are some maps with particle systems with dynamic lights, so not everything can be made the same by only adjusting the game’s own assets.

Which maps?

For example usstremor at viewpos 112 -306 86 6 2. Here is an index where all map particle systems with one can be found under dynamiclight. (Map trail systems could use them too, but none do.)

Also there are some places where dynamic light intensities from config files are clamped to [0, 1] (yeah that’s stupid and shouldn’t be done), so that’s something we would need to watch out for if adjusting configs.

Yes, that is particles and beams/trails. Those look fine though.

We have particle and trail systems using dynamic lights in res-weapons, but I don't see any updates for them in UnvanquishedAssets/res-weapons_src.dpkdir#32.

Why don't we just add back the scaling factors to anywhere the lights are used on the gamelogic side? This is an easy way to avoid unwanted changes to assets. I doubt designers are coming in with a specific expectation like 'the illumination should be equivalent to fullbright at distance 200 with intensity 17.4', so the arbitrary factor doesn't hurt anything.

[VReaperV]

For example usstremor at viewpos 112 -306 86 6 2. Here is an index where all map particle systems with one can be found under dynamiclight. (Map trail systems could use them too, but none do.)

Thanks, I'll test those once I update this/Unvanquished-side branch.

We have particle and trail systems using dynamic lights in res-weapons, but I don't see any updates for them in UnvanquishedAssets/res-weapons_src.dpkdir#32.

I tried with those initially, but they ended up looking wrong because of the 8-bit precision limit.

Why don't we just add back the scaling factors to anywhere the lights are used on the gamelogic side? This is an easy way to avoid unwanted changes to assets. I doubt designers are coming in with a specific expectation like 'the illumination should be equivalent to fullbright at distance 200 with intensity 17.4', so the arbitrary factor doesn't hurt anything.

I agree, I've been thinking about doing just that.

[VReaperV]

We have particle and trail systems using dynamic lights in res-weapons, but I don't see any updates for them in UnvanquishedAssets/res-weapons_src.dpkdir#32.

Why don't we just add back the scaling factors to anywhere the lights are used on the gamelogic side? This is an easy way to avoid unwanted changes to assets. I doubt designers are coming in with a specific expectation like 'the illumination should be equivalent to fullbright at distance 200 with intensity 17.4', so the arbitrary factor doesn't hurt anything.

I've added a fix for that to the Unvanquished-side pr. Both the dynamic lights on maps and those produced by weapons look fine to me with that change.