Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add r_materialSystemSkip #1478

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Conversation

VReaperV
Copy link
Contributor

@VReaperV VReaperV commented Dec 26, 2024

Picked from #1473.

This makes debugging issues that are present on material system but not core renderer (or vice versa), as well as comparing performance, much faster, since it can be changed without any sort of restart.

This makes debugging issues that are present on material system but no core renderer much faster, since it can be changed without any sort of restart.
@VReaperV VReaperV added T-Improvement Improvement for an existing feature A-Renderer labels Dec 26, 2024
@slipher
Copy link
Member

slipher commented Jan 11, 2025

LGTM, successfully tested.

@illwieckz
Copy link
Member

Nitpicking, but maybe r_skipMaterialSystem is a better name?

@VReaperV
Copy link
Contributor Author

I suppose so. My thinking originally was to group material system cvars under r_material*, but then GPU culling has different naming anyway... One other r_skip* cvar also exists, so that makes sense.

@VReaperV
Copy link
Contributor Author

But then there's also r_materialDebug... I'll keep at as is for now. If needed, it can be renamed later, especially as this is cvar is intended for debugging/profiling.

@VReaperV VReaperV merged commit 3135902 into DaemonEngine:master Jan 11, 2025
9 checks passed
@VReaperV VReaperV deleted the material-skip branch January 11, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Renderer T-Improvement Improvement for an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants