[CI] Do not allow yarn.lock to be updated in CI #5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user updates package.json in a PR, we need to ensure that the yarn.lock file is also updated in the same PR. This change will fail the `yarn install` command in case the yarn.lock is not in sync with package.json.
Overall package sizeSelf size: 8.55 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.0 | 9.8 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2025-01-30 09:48:45 Comparing candidate commit d74aec8 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 909 metrics, 24 unstable metrics. |
IlyasShabi
approved these changes
Jan 20, 2025
rochdev
approved these changes
Jan 29, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5135 +/- ##
=======================================
Coverage 81.07% 81.07%
=======================================
Files 479 479
Lines 21338 21338
=======================================
Hits 17299 17299
Misses 4039 4039 ☔ View full report in Codecov by Sentry. |
|
Failing CI is unrelated (see Slack thread). I'll merge |
szegedi
pushed a commit
that referenced
this pull request
Jan 30, 2025
If the user updates package.json in a PR, we need to ensure that the yarn.lock file is also updated in the same PR. This change will fail the `yarn install` command in case the yarn.lock is not in sync with package.json.
Merged
szegedi
pushed a commit
that referenced
this pull request
Jan 30, 2025
If the user updates package.json in a PR, we need to ensure that the yarn.lock file is also updated in the same PR. This change will fail the `yarn install` command in case the yarn.lock is not in sync with package.json.
szegedi
pushed a commit
that referenced
this pull request
Jan 30, 2025
If the user updates package.json in a PR, we need to ensure that the yarn.lock file is also updated in the same PR. This change will fail the `yarn install` command in case the yarn.lock is not in sync with package.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Do not allow
yarn.lockto be updated in CI.If the user updates
package.jsonin a PR, we need to ensure that theyarn.lockfile is also updated in the same PR. This change will fail theyarn installcommand in case theyarn.lockis not in sync withpackage.json.Motivation
We sometimes have a situation where a user forgets to commit changes to
yarn.lockwhen they make changes to the dependencies inpackage.json.Plugin Checklist
Additional Notes