Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refine] Implement Run Query button based on the UI design #478

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

kentwelcome
Copy link
Member

@kentwelcome kentwelcome commented Nov 7, 2024

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
UI Refine

What this PR does / why we need it:

  • Refine the Run Query button based on the new UI design
    CleanShot 2024-11-07 at 15 55 36

  • Refine the Primary key input field based on the new UI design
    CleanShot 2024-11-08 at 18 24 23
    CleanShot 2024-11-08 at 18 24 41

  • Align the base and current position
    CleanShot 2024-11-08 at 18 41 47

Which issue(s) this PR fixes:
DRC-768
DRC-860

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@kentwelcome kentwelcome marked this pull request as ready for review November 8, 2024 10:25
- When enable custom query mode, the base query should be left.
The current query should be right.

Signed-off-by: Kent Huang <[email protected]>
@kentwelcome kentwelcome merged commit 0e8b89a into main Nov 11, 2024
4 checks passed
@kentwelcome kentwelcome deleted the feature/drc-768-query-page-relayout branch November 11, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant