[Feature] Add telemetry for preview change #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcchang1115
requested review from
kentwelcome
and removed request for
kentwelcome
Base automatically changed from
feature/drc-971-beta-view-page-for-the-preview-change
to
main
December 23, 2024 06:54
wcchang1115
force-pushed
the
feature/drc-973-telemetry-for-preview-change
branch
from
dbba07f to
d634ebe
Compare
kentwelcome
reviewed
Dec 23, 2024
js/src/lib/api/track.ts
Outdated
| @@ -39,3 +39,20 @@ interface HistoryActionProps { | |||
| export function trackHistoryAction(props: HistoryActionProps) { | |||
| amplitude.track("[Web] history_action", props); | |||
| } | |||
|
|
|||
| interface PreviewChangeProps { | |||
| action: "explore" | "run"; | |||
There was a problem hiding this comment.
Should we record a close event?
There was a problem hiding this comment.
yes, we should record user who just leave without action
thanks!
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
wcchang1115
force-pushed
the
feature/drc-973-telemetry-for-preview-change
branch
from
053d5b4 to
acf5270
Compare
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What type of PR is this?
Feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
DRC-971
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE