NEW FEATURE: variables in number fields #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kerolasa @lianapanatau-ionos @wdbaker-godaddy please take look here as well if this update makes sense to you |
Signed-off-by: Sami Kerola <[email protected]>
pawel-kow
requested review from
wdbaker-godaddy,
lianapanatau-ionos and
kerolasa
|
Just to be explicit the string-number-variables can be expressed in template three different ways, and these need to be equal (assuming variable expansion results to same numeric value). After a template is processed the value MUST to be numeric. I think that's right, right? |
|
@kerolasa correct. Is there any edit to the text needed to make it clear? |
|
The Int or string representation of Int is probably good enough. I will try to make dc-template-linter to work with int-string-variables sometime soon(ish). |
kerolasa
added a commit
to Domain-Connect/dc-template-linter
that referenced
this pull request
Aug 5, 2024
After this change numbers are always quoted after reformatting. That is the
only way to be somewhat consistent what is the representation format when
%variables% need to be supported, and they need to be strings.
As a practical example, one could have the following in a template (and it
would fail, but it's obvious why - see the hostname).
"records": [
{
"type": "A",
"host": "the-ttl-is-plain-number-this-is-ok",
"ttl": 1800
},
{
"type": "A",
"host": "the-ttl-is-quoted-number-this-is-ok",
"ttl": "8100"
},
{
"type": "A",
"host": "the-ttl-is-variable-this-is-ok",
"ttl": "%varttl%"
},
{
"type": "A",
"host": "ttl-is-BROKEN-it-cannot-be-just-a-string",
"ttl": "just-a-string"
}
]
Reference: Domain-Connect/spec#100
Signed-off-by: Sami Kerola <[email protected]>
kerolasa
approved these changes
Aug 8, 2024
kerolasa
added a commit
to Domain-Connect/dc-template-linter
that referenced
this pull request
Aug 14, 2024
After this change numbers are always quoted after reformatting. That is the
only way to be somewhat consistent what is the representation format when
%variables% need to be supported, and they need to be strings.
As a practical example, one could have the following in a template (and it
would fail, but it's obvious why - see the hostname).
"records": [
{
"type": "A",
"host": "the-ttl-is-plain-number-this-is-ok",
"ttl": 1800
},
{
"type": "A",
"host": "the-ttl-is-quoted-number-this-is-ok",
"ttl": "8100"
},
{
"type": "A",
"host": "the-ttl-is-variable-this-is-ok",
"ttl": "%varttl%"
},
{
"type": "A",
"host": "ttl-is-BROKEN-it-cannot-be-just-a-string",
"ttl": "just-a-string"
}
]
Reference: Domain-Connect/spec#100
Signed-off-by: Sami Kerola <[email protected]>
|
I have reviewed with DEV and they will approve the pull request. |
wdbaker-godaddy
approved these changes
Oct 10, 2024
pawel-kow
pushed a commit
that referenced
this pull request
Oct 20, 2024
|
This change is now under community vote: https://domainconnect.slack.com/archives/CBTKX8R4G/p1736188710187489 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses issue #88