-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump JamesIves/github-pages-deploy-action from 4.6.0 to 4.6.1 #38
Bump JamesIves/github-pages-deploy-action from 4.6.0 to 4.6.1 #38
Conversation
Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.6.0 to 4.6.1. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@v4.6.0...v4.6.1) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
@@ -24,7 +24,7 @@ jobs: | |||
-D STEPS=clean\;configure\;docs | |||
-S FairCMakeModules_test.cmake | |||
- name: Deploy | |||
uses: JamesIves/[email protected].0 | |||
uses: JamesIves/[email protected].1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dennisklein: I think, we should just use the latest patch version (in the hope that they get the semantic versioning correct). What do you think?
uses: JamesIves/[email protected].1 | |
uses: JamesIves/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? Dont we want to benefit from bug fixes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had assumed that 4.6
means "take the latest patch release in the 4.6.*
range? So it should get us all bug fixes in 4.6 without even getting a PR like this one?
Getting a PR like this one for feature updates or even breaking changes is good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, now I understand. I agree, let's use the least specific version that makes sense.
Looks like JamesIves/github-pages-deploy-action is up-to-date now, so this is no longer needed. |
Looks like dependabot agrees that the less specific variant works. |
Bumps JamesIves/github-pages-deploy-action from 4.6.0 to 4.6.1.
Release notes
Sourced from JamesIves/github-pages-deploy-action's releases.
Commits
5c6e9e9
Deploy Production Code for Commit e9abb9ce6e35175032a1e82dd997ac600ad10c9b 🚀e9abb9c
Merge branch 'dev' into releases/v4079c29c
build(deps-dev): bump the misc group with 2 updates (#1593)e0e9b96
build(deps): bump the eslint group with 3 updates (#1592)dfda814
Merge branch 'dev' of https://github.com/JamesIves/github-pages-deploy-action...c282185
chore: update dependabot groups91fd6ee
fix: 🐛 Use commish to make branch unique (#1591)5bb052c
build(deps): bump typescript-eslint from 7.8.0 to 7.9.0 (#1586)ef33bcd
build(deps): bump codecov/codecov-action from 4.3.0 to 4.4.0 (#1588)1a64cb8
build(deps-dev): bump rimraf from 5.0.5 to 5.0.7 (#1583)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)