Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump JamesIves/github-pages-deploy-action from 4.6.0 to 4.6.1 #38

Closed
wants to merge 1 commit into from
Closed

Bump JamesIves/github-pages-deploy-action from 4.6.0 to 4.6.1 #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
-D STEPS=clean\;configure\;docs
-S FairCMakeModules_test.cmake
- name: Deploy
uses: JamesIves/[email protected].0
uses: JamesIves/[email protected].1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dennisklein: I think, we should just use the latest patch version (in the hope that they get the semantic versioning correct). What do you think?

Suggested change
uses: JamesIves/[email protected].1
uses: JamesIves/[email protected]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Dont we want to benefit from bug fixes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had assumed that 4.6 means "take the latest patch release in the 4.6.* range? So it should get us all bug fixes in 4.6 without even getting a PR like this one?

Getting a PR like this one for feature updates or even breaking changes is good!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, now I understand. I agree, let's use the least specific version that makes sense.

with:
branch: gh-pages
folder: build/docs/html
Expand Down