Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tracking ID in customer profile from Shipstation #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dankoknad
Copy link
Contributor

No description provided.

@dankoknad
Copy link
Contributor Author

@@ -45,7 +45,7 @@ const OrderRow = props => {
<span>{stateTitles[order.state]}</span>
</td>
<td>
TRACKING ID
{order.shippingMethod.id}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're looking for the tracking number -- correct me if I'm wrong, but this looks like the ID of the shipping method (the primary key of our shipping method in the DB). This won't have any relevance to the user.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmataya thank's Jeff. it was my assumption that {order.shippingMethod.id} is what i needed here, but was not sure about that.

that is why i have asked @jessicakwalters for help:
"@jessicawalters6 i can't get similar IDs from this API: ttps://stage-tpg.foxcommerce.com (frontend and admin). would you allow me to access to some account (client side) which pulls production API in order to check if i am using right endpoint? thanks."

on this page http://www.shipstation.com/developer-api/#/introduction/integrating-with-shipstation i have found that right property shold look like this: "trackingNumber": "913492493294329421". however, haven't find anything similar in props which component receives. any idea what i am missing here? thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmataya btw, inside shippingMethod property (OrderRow component) there are two child properties: "id" and "shippingMethodId". i guess none of these is what we are looking for?

@dankoknad
Copy link
Contributor Author

communication from slack (#ui, 02/01/17):

me: <OrderRow /> component receives order object which has shippingMethod key, and shippingMethod key has two (among others) properties: id and shippingMethodId. at some point i thought that id (type == = number) couldbe trackingNumber, but i guess it's not the case. thanks in advance!

@anru: I think @frontend is not perfect target for that question 🙂 Recently Max changed the way how orders comes to storefronts (see FoxComm/api-js#32). And I guess all required data should be in /v1/my/orders. And if there is no tracking number, where @danko could get it ? cc @mempko_fox

@jmataya: @anru @danko tracking number isn't part of an order, it's part of a shipment
To get tracking number you'll either need to call the shipments API or we need to think about how to add tracking number to the orders API
Theoretically, we could consider powering this whole view via the shipments API
Or figure out some UX for displaying the shipment as part of the order

@eugene-sy
Copy link
Contributor

@jmataya: @anru @danko what is the status of this PR? should we close it or finish & merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants