Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tracking ID in customer profile from Shipstation #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added tracking ID in customer profile from Shipstation #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/profile/blocks/my-orders.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class MyOrders extends Component {
<th>Order #</th>
<th>Total</th>
<th>Status</th>
<th>Tracking</th>
<th>Tracking ID</th>
<th>&nbsp;</th>
</tr>
</thead>
Expand Down
2 changes: 1 addition & 1 deletion src/components/profile/blocks/order-row.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const OrderRow = props => {
<span>{stateTitles[order.state]}</span>
</td>
<td>
TRACKING ID
{order.shippingMethod.id}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're looking for the tracking number -- correct me if I'm wrong, but this looks like the ID of the shipping method (the primary key of our shipping method in the DB). This won't have any relevance to the user.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmataya thank's Jeff. it was my assumption that {order.shippingMethod.id} is what i needed here, but was not sure about that.

that is why i have asked @jessicakwalters for help:
"@jessicawalters6 i can't get similar IDs from this API: ttps://stage-tpg.foxcommerce.com (frontend and admin). would you allow me to access to some account (client side) which pulls production API in order to check if i am using right endpoint? thanks."

on this page http://www.shipstation.com/developer-api/#/introduction/integrating-with-shipstation i have found that right property shold look like this: "trackingNumber": "913492493294329421". however, haven't find anything similar in props which component receives. any idea what i am missing here? thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmataya btw, inside shippingMethod property (OrderRow component) there are two child properties: "id" and "shippingMethodId". i guess none of these is what we are looking for?

</td>
{detailsColumn}
</tr>
Expand Down