Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed PDBs #412

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Embed PDBs #412

merged 2 commits into from
Jan 7, 2025

Conversation

sungam3r
Copy link
Contributor

@sungam3r sungam3r commented Jan 3, 2025

Replaces #14

@sungam3r sungam3r mentioned this pull request Jan 3, 2025
Closed
marcin-krystianc
marcin-krystianc reviewed Jan 7, 2025
View reviewed changes
Directory.Build.props
@@ -8,8 +8,8 @@
<PackageReleaseNotes>https://github.com/G-Research/consuldotnet/blob/master/CHANGELOG.md</PackageReleaseNotes>
<PackageProjectUrl>https://consuldot.net</PackageProjectUrl>
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
<RepositoryType>git</RepositoryType>
<RepositoryUrl>https://github.com/G-Research/consuldotnet</RepositoryUrl>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering why we don't need to add the reference to the Microsoft.SourceLink.GitHub package, but according to the docs (https://github.com/dotnet/sourcelink?tab=readme-ov-file#using-source-link-in-net-projects), it is not needed anymore (starting with .NET 8).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

marcin-krystianc
marcin-krystianc approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@marcin-krystianc marcin-krystianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks sungam3r, it looks good 👍

@marcin-krystianc marcin-krystianc merged commit adac038 into G-Research:master Jan 7, 2025
240 of 242 checks passed
@sungam3r sungam3r deleted the sourcelink branch January 7, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcin-krystianc marcin-krystianc marcin-krystianc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sungam3r @marcin-krystianc