Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed PDBs #412

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Embed PDBs #412

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea96e06
Embed PDBs
sungam3r Jan 3, 2025
e6be38e
Update Directory.Build.props
sungam3r Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Consul.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,22 @@

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 16
VisualStudioVersion = 16.0.29009.5
# Visual Studio Version 17
VisualStudioVersion = 17.12.35514.174 d17.12
MinimumVisualStudioVersion = 10.0.40219.1
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Consul", "Consul\Consul.csproj", "{B763F0CA-2BED-49FE-A2FB-2659FDE6222B}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Consul.Test", "Consul.Test\Consul.Test.csproj", "{59CA6048-E8D0-46BF-997B-FEB7083C42C2}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{C179F190-BAED-417B-A2E8-AF36BE6A5F1F}"
ProjectSection(SolutionItems) = preProject
.editorconfig = .editorconfig
.gitattributes = .gitattributes
.gitignore = .gitignore
.globalconfig = .globalconfig
CHANGELOG.md = CHANGELOG.md
NuGet.config = NuGet.config
Directory.Build.props = Directory.Build.props
LICENSE = LICENSE
MAINTAINERS.md = MAINTAINERS.md
README.md = README.md
EndProjectSection
EndProject
Expand Down
5 changes: 3 additions & 2 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@
<PackageReleaseNotes>https://github.com/G-Research/consuldotnet/blob/master/CHANGELOG.md</PackageReleaseNotes>
<PackageProjectUrl>https://consuldot.net</PackageProjectUrl>
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
<RepositoryType>git</RepositoryType>
<RepositoryUrl>https://github.com/G-Research/consuldotnet</RepositoryUrl>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering why we don't need to add the reference to the Microsoft.SourceLink.GitHub package, but according to the docs (https://github.com/dotnet/sourcelink?tab=readme-ov-file#using-source-link-in-net-projects), it is not needed anymore (starting with .NET 8).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

<DebugType>embedded</DebugType>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
sungam3r marked this conversation as resolved.
Show resolved Hide resolved
<Authors>G-Research</Authors>
<PublicSign>true</PublicSign>
<AssemblyOriginatorKeyFile>../assets/consuldotnet.snk</AssemblyOriginatorKeyFile>
Expand Down
8 changes: 0 additions & 8 deletions nuget.config
View file
Open in desktop

This file was deleted.

Loading