Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create test suite for remap_restarts.py #267

Merged
merged 15 commits into from
Jul 22, 2022
Merged

Create test suite for remap_restarts.py #267

merged 15 commits into from
Jul 22, 2022

Conversation

weiyuan-jiang
Copy link
Contributor

This PR addresses issue #265. It can be merged independently upon PR #238 but would not work until #238 is merged

@weiyuan-jiang weiyuan-jiang added enhancement New feature or request 0 diff The changes in this pull request have verified to be zero-diff with the target branch. labels Jun 20, 2022
@weiyuan-jiang weiyuan-jiang requested review from a team as code owners June 20, 2022 16:42
mathomp4
mathomp4 reviewed Jun 21, 2022
View reviewed changes
GEOS_Util/post/tests/test_remap_restarts.py Outdated
if __name__ == '__main__' :

# test c24_to_c12
base_c12 = '/gpfsm/dnb32/wjiang/pl_c24Tc12'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should put these files/etc. used for the tests in our gmao_SIteam space? Then it's at least in a "generic" directory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, eventually those hard coded path should be moved to somewhere before it is merged

@mathomp4 mathomp4 requested a review from tclune June 22, 2022 18:25
sdrabenh
sdrabenh previously approved these changes Jul 21, 2022
View reviewed changes
@mathomp4 mathomp4 requested a review from a team as a code owner July 21, 2022 14:39
@gmao-rreichle gmao-rreichle linked an issue Jul 21, 2022 that may be closed by this pull request
Define test suite for remap_restarts.py #265
Open
@gmao-rreichle gmao-rreichle changed the title Feature/wjiang/add tests Create test suite for remap_restarts.py Jul 21, 2022
@mathomp4 mathomp4 self-requested a review July 22, 2022 18:46
mathomp4
mathomp4 reviewed Jul 22, 2022
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapprove!

@mathomp4
Copy link
Member

Not sure what's going on with approvals. I'll superpower it in.

@mathomp4 mathomp4 merged commit 28fe9c1 into main Jul 22, 2022
@mathomp4 mathomp4 deleted the feature/wjiang/add_tests branch July 22, 2022 18:48
@gmao-rreichle gmao-rreichle mentioned this pull request Jul 22, 2022
Open
@gmao-rreichle gmao-rreichle mentioned this pull request Aug 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 left review comments

@sdrabenh sdrabenh sdrabenh approved these changes

@tclune tclune Awaiting requested review from tclune

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define test suite for remap_restarts.py
3 participants
@weiyuan-jiang @mathomp4 @sdrabenh