Create test suite for remap_restarts.py #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiyuan-jiang
added
enhancement
mathomp4
reviewed
Jun 21, 2022
| if __name__ == '__main__' : | ||
|
|
||
| # test c24_to_c12 | ||
| base_c12 = '/gpfsm/dnb32/wjiang/pl_c24Tc12' |
There was a problem hiding this comment.
I wonder if we should put these files/etc. used for the tests in our gmao_SIteam space? Then it's at least in a "generic" directory?
There was a problem hiding this comment.
Yes, eventually those hard coded path should be moved to somewhere before it is merged
sdrabenh
previously approved these changes
Jul 21, 2022
gmao-rreichle
changed the title
sdrabenh
approved these changes
Jul 22, 2022
|
Not sure what's going on with approvals. I'll superpower it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #265. It can be merged independently upon PR #238 but would not work until #238 is merged