Fix SoundManager handling when no sound devices exist #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eigenraven
reviewed
Sep 13, 2024
| @@ -64,6 +64,10 @@ public static void create(String deviceArguments, int contextFrequency, int cont | |||
|
|
|||
| long deviceHandle = org.lwjgl.openal.ALC10.alcOpenDevice(defaultDevice); | |||
|
|
|||
| if (deviceHandle == 0) { | |||
| throw new org.lwjgl.LWJGLException("Could not open ALC device"); | |||
There was a problem hiding this comment.
The mappings should only throw the lwjglx exceptions, not lwjgl - change this here and remove the double throws clauses above. The class references are remapped from x to no x in an asm transformer later
There was a problem hiding this comment.
Changed to lwgjlx variant. I think we still need the throws above because the create calls are chained.
fix error type
kstvr32
force-pushed
the
dev/kstvr/sound-crash-fix
branch
from
ead5107 to
e045927
Compare
eigenraven
approved these changes
Sep 13, 2024
|
Does that commit resumes the sound? |
|
This changes back to standard 1.7.10 behavior of turning to silent mode. You can manually reload the sound by pressing F3 + T |
This was referenced Oct 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes GTNewHorizons/Hodgepodge#420 as a fix for the SoundManager NPE crashes
Fixes GTNewHorizons/GT-New-Horizons-Modpack#17190
Fixes GTNewHorizons/GT-New-Horizons-Modpack#17190
Fixes GTNewHorizons/GT-New-Horizons-Modpack#16281
Fixes GTNewHorizons/GT-New-Horizons-Modpack#12848
Fixes GTNewHorizons/Hodgepodge#406
Adds null check that is present in LWJGL2 when initializing OpenAL sound.