Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SoundManager handling when no sound devices exist #173

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Fix SoundManager handling when no sound devices exist #173

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e045927
add null check to mimic behavior of lwjgl2
Sep 13, 2024
51d3e0d
Merge branch 'master' into dev/kstvr/sound-crash-fix
Dream-Master Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/java/org/lwjglx/openal/AL.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ public static void create() throws LWJGLException {
}

public static void create(String deviceArguments, int contextFrequency, int contextRefresh,
boolean contextSynchronized) {
boolean contextSynchronized) throws LWJGLException {
create(deviceArguments, contextFrequency, contextRefresh, contextSynchronized, true);
}

public static void create(String deviceArguments, int contextFrequency, int contextRefresh,
boolean contextSynchronized, boolean openDevice) {
boolean contextSynchronized, boolean openDevice) throws LWJGLException {
IntBuffer attribs = BufferUtils.createIntBuffer(16);

attribs.put(org.lwjgl.openal.ALC10.ALC_FREQUENCY);
Expand Down Expand Up @@ -64,6 +64,10 @@ public static void create(String deviceArguments, int contextFrequency, int cont

long deviceHandle = org.lwjgl.openal.ALC10.alcOpenDevice(defaultDevice);

if (deviceHandle == 0) {
throw new LWJGLException("Could not open ALC device");
}

alcDevice = new ALCdevice(deviceHandle);
final ALCCapabilities deviceCaps = org.lwjgl.openal.ALC.createCapabilities(deviceHandle);

Expand Down