Maroon-399 Tools UI #409

dpdsw · 2022-08-19T18:21:27Z

Hi, please have a look at the position of the files.
closes #399

michaelholly

Please see the request changes,

Use the Experiment Template scene for the CoulombsLawRemake
Use the UI Prefab for the CoulombsLawRemake otherwise the UI layout is not correct
The CoulombsLawRemake simulation is not working when playing the simulation
Toolkit UI overlaps with Dialog View
Tools like Ruler are not working in the other scenes
Please move all experiment relevant scripts into the corresponding experiment folder

michaelholly · 2022-09-21T08:00:35Z

unity/Assets/Maroon/reusableGui/Experiment/Prefab/Particle.prefab

@@ -0,0 +1,583 @@
+%YAML 1.1


Please move this prefab to the experiment folder.

michaelholly · 2022-09-21T09:08:02Z

unity/Assets/Maroon/reusableGui/Experiment/Scripts/Runtime/ToggleUIElement.cs

@@ -1,18 +0,0 @@
-//


Please do not remove this file. This is used in the Optics experiment scene.

renamed to ToggleToolUI.cs?

This should be back again and work properly in the optics experiment

michaelholly · 2022-09-21T09:10:58Z

unity/Assets/Maroon/reusableGui/Experiment/ToolsUI/ColoumbsLawRemake.pc.unity.meta

@@ -0,0 +1,7 @@
+fileFormatVersion: 2


Please move the ColoumbsLawRemake scene to the ColoumbsLaw experiment folder.

michaelholly · 2022-09-21T09:13:08Z

unity/Assets/Maroon/reusableGui/Experiment/ToolsUI/ColoumbsLawRemake.pc.unity.meta

@@ -0,0 +1,7 @@
+fileFormatVersion: 2
+guid: 2e69c3f8c37d40e49ac178de75fa1cf0


Please copy the experiment room template scene and add your changes to this scene. Otherwise, the experiment room setting is missing.

michaelholly · 2022-09-21T09:24:29Z

unity/Assets/Maroon/reusableGui/Experiment/ToolsUI/Scripts/PC_ObjectSelection.cs

+using System.Collections.Generic;
+using UnityEngine;
+
+namespace Assets.Maroon.reusableGui.Experiment.ToolsUI.Scripts


please change the namespace to Maroon.UI

michaelholly · 2022-09-21T11:33:17Z

unity/Assets/Maroon/reusableGui/Experiment/ToolsUI/Scripts/PC_ObjectSelectionHandler.cs

+using UnityEngine;
+using UnityEngine.UI;
+
+namespace Assets.Maroon.reusableGui.Experiment.ToolsUI.Scripts


Please change the namespace to Maroon.UI

michaelholly · 2022-09-21T11:50:34Z

unity/Assets/Maroon/reusableGui/Experiment/ToolsUI/Scripts/PC_ObjectSelectionHandler.cs

+
+namespace Assets.Maroon.reusableGui.Experiment.ToolsUI.Scripts
+{
+    public class PC_ObjectSelectionHandler : MonoBehaviour 


is it just for particle selection? if yes maybe use another name

michaelholly · 2022-09-21T11:50:55Z

unity/Assets/Maroon/reusableGui/Experiment/ToolsUI/Scripts/PC_ObjectSelectionHandler.cs

+    public class PC_ObjectSelectionHandler : MonoBehaviour 
+    {
+        [SerializeField] private GameObject inputXVariable;
+        [SerializeField] private GameObject inputYVariable;


what about an inputZVariable?

michaelholly · 2022-09-21T12:34:23Z

unity/Assets/Maroon/reusableGui/Experiment/ToolsUI/Scripts/ParticleManager.cs

+using Maroon.Physics.Electromagnetism;
+using UnityEngine;
+
+public class ParticleManager : MonoBehaviour


Please move this to the experiment scene folder

michaelholly · 2022-09-21T12:39:21Z

unity/Assets/Maroon/reusableGui/Experiment/ToolsUI/Scripts/UIParticleDragHandler.cs

+using UnityEngine.EventSystems;
+using UnityEngine.UI;
+
+namespace Assets.Maroon.reusableGui.Experiment.ToolsUI.Scripts


Please change the namespace.
This script should also be moved to the experiment folder

Fix issue

FlorianGlawogger

Generally speaking a great addition and I'm sure lots of new and old experiments will benefit from such a Tools UI 👍 what's IMO the biggest issue right now is that some functionality from Coulomb's Law experiment is missing now (e.g. 3D variant), and made some suggestions how code might be a bit more readable, but feel free to add your own suggestions/feedback to that

unity/Assets/Maroon/scenes/experiments/CoulombsLaw/CoulombsLaw.pc.unity.meta

unity/Assets/Maroon/scenes/experiments/CoulombsLaw/CoulombsLaw.pc.unity

FlorianGlawogger · 2024-11-13T11:03:30Z

unity/Assets/Maroon/scenes/experiments/CoulombsLaw/CoulombsLaw.pc.unity

German translation not working in the scene

FlorianGlawogger · 2024-11-13T11:08:16Z

unity/Assets/Maroon/reusablePrefabs/toolSuite/Prefab/ToolSuite.prefab

Is this used anywhere? if not can it be deleted

FlorianGlawogger · 2024-11-13T12:01:59Z

unity/Assets/Maroon/reusableGui/Experiment/ToolsUI/Scripts/ToolDictionary.cs

IMO the name ToolDictionary implies this contains a Dictionary, with a key value storage, but it's just a list, so I'd suggest renaming this class;

unity/Assets/Maroon/scenes/experiments/CoulombsLaw/Scripts/PC_ObjectSelection.cs

unity/Assets/Maroon/scenes/experiments/CoulombsLaw/Scripts/PC_ObjectSelectionHandler.cs

unity/Assets/Maroon/scenes/experiments/CoulombsLaw/Scripts/ParticleManager.cs

FlorianGlawogger · 2024-11-20T12:19:39Z

Also just noticed in the Maroon web verison, there is an outline of selected charge, like so:

I think it's missing now

FlorianGlawogger

A lot better already, though I think there are still some unresolved issues from my last review, and I found a few more things that don't yet work, but otherwise looks already good👍

EDIT: also needs to be merged, conflicts need to be resolved

FlorianGlawogger · 2024-12-18T14:01:33Z

unity/Assets/Maroon/reusableGui/Experiment/Scripts/Runtime/ToggleUIElement.cs

sorry, but I can't seem to find out if this file is used anywhere?

FlorianGlawogger · 2024-12-18T14:20:24Z

unity/Assets/Maroon/scenes/experiments/CoulombsLaw/CoulombsLaw.pc.unity

the charges can be forced out of the whiteboard area somehow:
https://github.com/user-attachments/assets/6a185f42-6162-488c-9fe0-ec9aac8b0be5

Also get many errors

FlorianGlawogger · 2024-12-18T14:22:46Z

unity/Assets/Maroon/scenes/experiments/CoulombsLaw/CoulombsLaw.pc.unity

Neutral charges are now white, previously they were green

(here is what it looks like on maroon.tugraz.at )

FlorianGlawogger · 2024-12-18T14:23:25Z

unity/Assets/Maroon/scenes/experiments/CoulombsLaw/CoulombsLaw.pc.unity

Add charge button not translated

FlorianGlawogger · 2024-12-18T14:26:02Z

unity/Assets/Maroon/scenes/experiments/CoulombsLaw/CoulombsLaw.pc.unity

IMO there shouldn't be line breaks between x and :, i.e. it should be x: instead of x\n: , same for y, z, nm, etc.

FlorianGlawogger · 2024-12-18T14:32:57Z

unity/Assets/Maroon/scenes/experiments/CoulombsLaw/CoulombsLaw.pc.unity

Measure distance points are also reset when pressing reset button, (not sure if that should be done tbh), and when reset, the line between them does not change:

resetMeasureDistance.mp4

Voltage measure pins are removed when resetting, maybe just remove distance measure things as well?

FlorianGlawogger · 2024-12-18T14:39:44Z

unity/Assets/Maroon/scenes/experiments/CoulombsLaw/CoulombsLaw.pc.unity

Outline of selected charges not visible, see #409 (comment)

dpdsw requested a review from michaelholly August 22, 2022 12:00

michaelholly requested changes Sep 21, 2022

View reviewed changes

Averimon self-assigned this Oct 29, 2024

dpdsw and others added 27 commits November 12, 2024 10:03

Add tools suite and leightweight version of Coulombs law experiment

bf10f35

Initial Commit

3971287

Added lightweight coulombslaw scene

3224428

Add leightweight version of coulombs law experiment

e6d5cbf

Update UIParticleDragHandler.cs

6e253a1

Fix issue

Remove uneccessary file

b3168ed

Change Canvas Render Mode to Overlay

d0c46a6

Added Simulation, Materials

d877e0e

Moved Files to according folders

ace744a

Moved to ExperimentSetting

183596a

Adapted Dragging

5b5e9e9

applieder scaling to UI

dd4c9c9

Added z input variable

5c5df5b

adapted namespace

8d22b81

fine tuning particle properties

c079147

fix CoordSystem calculations

150122f

Fixed scale of visualization

a98bd1d

Fixed dependency errors and warnings post merge

9f819b0

Changed coordinate system to micrometer

661aa15

Fixed shader + materials for ColoumbsLawRemake

4b83a11

Disabled z-axis movement for Voltmeter+Ruler pins

f4a1c32

Adjusted ruler and voltmeter to new unit (nanometer)

de1a627

Implemented ToolController

f6157e9

Swapped out old CoulombsLaw with Remake

7db4697

Changed pin colors of ruler

574490d

Fix Check fails (multiple UICameras+removed unknown script)

b4788ab

Removed deprecated ColumbsLaw

7d36e20

Averimon added 2 commits November 12, 2024 11:59

Fixed missing references

004e16c

Renamed CoulombsLaw scene

cfd5289

Averimon force-pushed the feature/Maroon-399_ToolsUI branch from 35df500 to cfd5289 Compare November 12, 2024 12:02

Averimon requested a review from FlorianGlawogger November 12, 2024 12:38

FlorianGlawogger changed the title ~~Feature/maroon 399 tools UI~~ Maroon-399 Tools UI Nov 13, 2024

FlorianGlawogger requested changes Nov 13, 2024

View reviewed changes

Averimon added 10 commits November 18, 2024 12:44

Bugfix: Add charge button works again

fc3c55f

Added Language file to CoulombsLaw

ad2bc77

Added VectorFieldVisualization and Toggle Vector Field

6953b50

Removed author comment and made Start methods private

c8d282e

Added Maroon.Experiments.CoulombsLaw namespace

73d5799

Simplified code

f9697a6

Fixed missing prefabs

b25269a

Made abstract IField functions non-abstract

0910bce

Capitalized function names

d243b0c

Fixed incorrect indentation

2e0238b

CoulombsLaw Physics improvements

c126883

FlorianGlawogger requested changes Dec 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Maroon-399 Tools UI #409

Maroon-399 Tools UI #409

dpdsw commented Aug 19, 2022 •

edited by michaelholly

Loading

michaelholly left a comment •

edited

Loading

michaelholly Sep 21, 2022

dpdsw Sep 24, 2022

michaelholly Sep 21, 2022

michaelholly Sep 21, 2022

dpdsw Sep 24, 2022

michaelholly Sep 21, 2022

dpdsw Sep 24, 2022

michaelholly Sep 21, 2022

dpdsw Sep 24, 2022

michaelholly Sep 21, 2022

michaelholly Sep 21, 2022

michaelholly Sep 21, 2022

michaelholly Sep 21, 2022

michaelholly Sep 21, 2022

michaelholly Sep 21, 2022

dpdsw Sep 24, 2022

FlorianGlawogger left a comment

FlorianGlawogger Nov 13, 2024

FlorianGlawogger Nov 13, 2024

FlorianGlawogger Nov 13, 2024

FlorianGlawogger commented Nov 20, 2024

FlorianGlawogger left a comment •

edited

Loading

FlorianGlawogger Dec 18, 2024

FlorianGlawogger Dec 18, 2024

FlorianGlawogger Dec 18, 2024

FlorianGlawogger Dec 18, 2024

FlorianGlawogger Dec 18, 2024

FlorianGlawogger Dec 18, 2024

FlorianGlawogger Dec 18, 2024

FlorianGlawogger Dec 18, 2024

FlorianGlawogger Dec 18, 2024

		@@ -0,0 +1,7 @@
		fileFormatVersion: 2
		guid: 2e69c3f8c37d40e49ac178de75fa1cf0

Maroon-399 Tools UI #409

Are you sure you want to change the base?

Maroon-399 Tools UI #409

Conversation

dpdsw commented Aug 19, 2022 • edited by michaelholly Loading

michaelholly left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FlorianGlawogger left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FlorianGlawogger commented Nov 20, 2024

FlorianGlawogger left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dpdsw commented Aug 19, 2022 •

edited by michaelholly

Loading

michaelholly left a comment •

edited

Loading

FlorianGlawogger left a comment •

edited

Loading