Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maroon-399 Tools UI #409
base: develop
Are you sure you want to change the base?
Maroon-399 Tools UI #409
Changes from 1 commit
bf10f35
3971287
3224428
e6d5cbf
6e253a1
b3168ed
d0c46a6
d877e0e
ace744a
183596a
5b5e9e9
dd4c9c9
5c5df5b
8d22b81
c079147
150122f
a98bd1d
9f819b0
661aa15
4b83a11
f4a1c32
de1a627
f6157e9
7db4697
574490d
b4788ab
7d36e20
004e16c
cfd5289
fc3c55f
ad2bc77
6953b50
c8d282e
73d5799
f9697a6
b25269a
0910bce
d243b0c
2e0238b
c126883
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
German translation not working in the scene
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Experiment does not support 3D anymore? Used to support 3D
screenshot from online version at https://maroon.tugraz.at/build/web/ where 3D is supported:
![grafik](https://private-user-images.githubusercontent.com/73254596/385769459-5a31b938-ea3e-4073-8710-9180f538c3df.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3MzMwMTYsIm5iZiI6MTczOTczMjcxNiwicGF0aCI6Ii83MzI1NDU5Ni8zODU3Njk0NTktNWEzMWI5MzgtZWEzZS00MDczLTg3MTAtOTE4MGY1MzhjM2RmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDE5MDUxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU1NmY5ZjQ3MTE5YjQzNDQ0NTMyOWE4M2YwZjMxNTA0ZDU4MTkzYTJmOGFhMDU1YWY0NjNlZDNhNzlhMzZjZTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.cnHyrQI9ggc3lp06hME0-Hg2ko-IEtIIGtnZa8oGDSI)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pressing Play does not seem to do anything anymore? Positive and negative carriers used to move towards each other.
Resetting experiment now deletes all carriers (used to simply reset carriers to their original position before pressing play, see experiment at https://maroon.tugraz.at/build/web/ )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the charges can be forced out of the whiteboard area somehow:
https://github.com/user-attachments/assets/6a185f42-6162-488c-9fe0-ec9aac8b0be5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also get many errors
![grafik](https://private-user-images.githubusercontent.com/73254596/396958539-4b4c141b-10a3-4636-9a12-e0e29fa860af.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3MzMwMTYsIm5iZiI6MTczOTczMjcxNiwicGF0aCI6Ii83MzI1NDU5Ni8zOTY5NTg1MzktNGI0YzE0MWItMTBhMy00NjM2LTlhMTItZTBlMjlmYTg2MGFmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDE5MDUxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ2MjgwZTE3MTg2MWU3MWNiNTRiYTgxZWI2NmY3NzYwNTk4MjIzMDY0MmUwMjhhOWE1NDhhYWMzOGJiMDY0MjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.0dDk7u9-dPlgNr46XV1wlAS06ZNZxg6uhZeg9MlSqmA)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neutral charges are now white, previously they were green
![grafik](https://private-user-images.githubusercontent.com/73254596/396959013-f7536616-2ac8-49fd-813b-06f845d4e22d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3MzMwMTYsIm5iZiI6MTczOTczMjcxNiwicGF0aCI6Ii83MzI1NDU5Ni8zOTY5NTkwMTMtZjc1MzY2MTYtMmFjOC00OWZkLTgxM2ItMDZmODQ1ZDRlMjJkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDE5MDUxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI5Mjk1OTRlYzZiMjBmMTkxYjRiYjIyMDUwZTAxNmRjOTg2MTQwOTE0NzJlNmFkYmI1YzFlMjBmMmE2NWU2YzQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.meSc_jyWsSW0dCEWA9uPl4xzOM1fmnnW1dBsvYsEEO4)
(here is what it looks like on maroon.tugraz.at )
![grafik](https://private-user-images.githubusercontent.com/73254596/396959161-f2f6063a-8780-4728-a574-82af127573b8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3MzMwMTYsIm5iZiI6MTczOTczMjcxNiwicGF0aCI6Ii83MzI1NDU5Ni8zOTY5NTkxNjEtZjJmNjA2M2EtODc4MC00NzI4LWE1NzQtODJhZjEyNzU3M2I4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDE5MDUxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRmZjk3OTdlNWQxMzRhZWI5ZjYyNmNiMjBkYTZiODVmODc0NTQyYWQzNzM0YTEzNGFlOGMxOThlNzFhNzBiZTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.-7JQwH3ofbMMSWi_rH8XACKkbYJ3zDeCiTWfn3CSJbI)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add charge button not translated
![grafik](https://private-user-images.githubusercontent.com/73254596/396959467-4c725c79-b348-4d7e-ba6b-21309eb431d1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3MzMwMTYsIm5iZiI6MTczOTczMjcxNiwicGF0aCI6Ii83MzI1NDU5Ni8zOTY5NTk0NjctNGM3MjVjNzktYjM0OC00ZDdlLWJhNmItMjEzMDllYjQzMWQxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDE5MDUxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM2NjJhZTU3Mzk2ZDNjYWY2YzBjM2E5MzhkZWU4NTljZDY1YmM1ZWIzMmQ5MmFkYjJmNmViOTQ2NWRhODkwNDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.AyPtKmbyLneGJa7RI7TffWywoh3myxbd_FqgfvVUv6g)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO there shouldn't be line breaks between x and :, i.e. it should be x: instead of x\n: , same for y, z, nm, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Measure distance points are also reset when pressing reset button, (not sure if that should be done tbh), and when reset, the line between them does not change:
resetMeasureDistance.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Voltage measure pins are removed when resetting, maybe just remove distance measure things as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outline of selected charges not visible, see #409 (comment)