Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maroon-399 Tools UI #409

Open
wants to merge 40 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
bf10f35
Add tools suite and leightweight version of Coulombs law experiment
dpdsw Aug 19, 2022
3971287
Initial Commit
dpdsw Aug 2, 2022
3224428
Added lightweight coulombslaw scene
dpdsw Aug 12, 2022
e6d5cbf
Add leightweight version of coulombs law experiment
dpdsw Aug 19, 2022
6e253a1
Update UIParticleDragHandler.cs
dpdsw Aug 19, 2022
b3168ed
Remove uneccessary file
dpdsw Aug 19, 2022
d0c46a6
Change Canvas Render Mode to Overlay
michaelholly Aug 29, 2022
d877e0e
Added Simulation, Materials
dpdsw Sep 12, 2022
ace744a
Moved Files to according folders
dpdsw Sep 24, 2022
183596a
Moved to ExperimentSetting
dpdsw Sep 24, 2022
5b5e9e9
Adapted Dragging
dpdsw Sep 24, 2022
dd4c9c9
applieder scaling to UI
dpdsw Sep 24, 2022
5c5df5b
Added z input variable
dpdsw Sep 24, 2022
8d22b81
adapted namespace
dpdsw Sep 24, 2022
c079147
fine tuning particle properties
dpdsw Sep 24, 2022
150122f
fix CoordSystem calculations
michaelholly Oct 3, 2022
a98bd1d
Fixed scale of visualization
dpdsw Oct 28, 2022
9f819b0
Fixed dependency errors and warnings post merge
Averimon Oct 2, 2024
661aa15
Changed coordinate system to micrometer
Averimon Oct 8, 2024
4b83a11
Fixed shader + materials for ColoumbsLawRemake
Averimon Oct 25, 2024
f4a1c32
Disabled z-axis movement for Voltmeter+Ruler pins
Averimon Oct 28, 2024
de1a627
Adjusted ruler and voltmeter to new unit (nanometer)
Averimon Oct 29, 2024
f6157e9
Implemented ToolController
Averimon Oct 29, 2024
7db4697
Swapped out old CoulombsLaw with Remake
Averimon Oct 29, 2024
574490d
Changed pin colors of ruler
Averimon Oct 29, 2024
b4788ab
Fix Check fails (multiple UICameras+removed unknown script)
Averimon Nov 12, 2024
7d36e20
Removed deprecated ColumbsLaw
Averimon Nov 12, 2024
004e16c
Fixed missing references
Averimon Nov 12, 2024
cfd5289
Renamed CoulombsLaw scene
Averimon Nov 12, 2024
fc3c55f
Bugfix: Add charge button works again
Averimon Nov 18, 2024
ad2bc77
Added Language file to CoulombsLaw
Averimon Nov 18, 2024
6953b50
Added VectorFieldVisualization and Toggle Vector Field
Averimon Nov 18, 2024
c8d282e
Removed author comment and made Start methods private
Averimon Nov 18, 2024
73d5799
Added Maroon.Experiments.CoulombsLaw namespace
Averimon Nov 18, 2024
f9697a6
Simplified code
Averimon Nov 18, 2024
b25269a
Fixed missing prefabs
Averimon Nov 18, 2024
0910bce
Made abstract IField functions non-abstract
Averimon Nov 18, 2024
d243b0c
Capitalized function names
Averimon Nov 18, 2024
2e0238b
Fixed incorrect indentation
Averimon Nov 18, 2024
c126883
CoulombsLaw Physics improvements
Averimon Dec 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bugfix: Add charge button works again
Averimon committed Nov 18, 2024
commit fc3c55f7553a780ece37fac8f7f03d8b3cd3563c
Averimon marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

German translation not working in the scene

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experiment does not support 3D anymore? Used to support 3D

screenshot from online version at https://maroon.tugraz.at/build/web/ where 3D is supported:
grafik

Averimon marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pressing Play does not seem to do anything anymore? Positive and negative carriers used to move towards each other.
Resetting experiment now deletes all carriers (used to simply reset carriers to their original position before pressing play, see experiment at https://maroon.tugraz.at/build/web/ )

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the charges can be forced out of the whiteboard area somehow:
https://github.com/user-attachments/assets/6a185f42-6162-488c-9fe0-ec9aac8b0be5

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also get many errors
grafik

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neutral charges are now white, previously they were green
grafik

(here is what it looks like on maroon.tugraz.at )
grafik

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add charge button not translated
grafik

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grafik
IMO there shouldn't be line breaks between x and :, i.e. it should be x: instead of x\n: , same for y, z, nm, etc.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Measure distance points are also reset when pressing reset button, (not sure if that should be done tbh), and when reset, the line between them does not change:

resetMeasureDistance.mp4

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voltage measure pins are removed when resetting, maybe just remove distance measure things as well?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outline of selected charges not visible, see #409 (comment)

Original file line number Diff line number Diff line change
@@ -18775,7 +18775,7 @@ MonoBehaviour:
inputYVariable: {fileID: 574776803}
inputZVariable: {fileID: 1256726598}
coulombValueSlider: {fileID: 9926214}
particlePrefab: {fileID: 7333818732060180029, guid: f958e0af013a3964980dba0ddee3de33,
particlePrefab: {fileID: 7333818732060180029, guid: 111fb891f106a394f8c451557d6558a0,
type: 3}
SourceButtonAddDelete: {fileID: 1940664970}
SourceButtonText: {fileID: 768139599}