Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test digitaltwin #2

Closed
wants to merge 6 commits into from
Closed

Test digitaltwin #2

wants to merge 6 commits into from

Conversation

jjm148
Copy link
Collaborator

@jjm148 jjm148 commented Jan 16, 2024

DESCRIPTION OF PR:

Unit test cases for the digitaltwin module

test_data_to_db is not working, unable to mock 'Engine'

Functions with 'Engine' as parameter were not tested

test_get_data_using_geoapis has 4 tests failing, will need to double-check if the failing unit tests are written correctly

Developer Checklist

  • Write tests
    • Create new tests
    • Ensure these tests have the expected behavior
    • Test locally and ensure tests are passing

Reviewer Checklist

  • Check new tests
    • Ensure adequate coverage
    • Check for code smells within tests
  • Check if documentation needs updating
    • Readme
    • Docstrings
    • Comments
    • Wiki

@caseyli92 caseyli92 changed the base branch from master to dynamic_building_outlines January 16, 2024 22:52
@LukeParky LukeParky changed the base branch from dynamic_building_outlines to master July 9, 2024 22:05
@LukeParky
Copy link
Member

We're moving this PR into the main codebase so any updates will be in GeospatialResearch#175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants